[
https://issues.apache.org/jira/browse/BEAM-1306?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kenneth Knowles updated BEAM-1306:
----------------------------------
This Jira ticket has a pull request attached to it, but is still open. Did the
pull request resolve the issue? If so, could you please mark it resolved? This
will help the project have a clear view of its open issues.
> Support additional configuration in BigQueryServices.insertAll()
> ----------------------------------------------------------------
>
> Key: BEAM-1306
> URL: https://issues.apache.org/jira/browse/BEAM-1306
> Project: Beam
> Issue Type: Improvement
> Components: io-java-gcp
> Reporter: Pei He
> Priority: P3
>
> ignoreUnknownValues is requested in
> https://issues.apache.org/jira/browse/BEAM-1267
> There are additional configurations that could be useful.
> TableDataInsertAllRequest content = new TableDataInsertAllRequest();
> content.setSkipInvalidRows();
> content.setTemplateSuffix();
> content.setKind();
>
> I think we can improve the BigQueryServices interface by define it as:
> void insertAll(TableReference ref, Collection<TableDataInsertAllRequest>
> request);
> and, provided a static method to prepare requests:
> List<TableDataInsertAllRequest> makeInsertBatches(List<TableRow> rowList,
> @Nullable List<String> insertIdList);
> Then, client can set additional config in the returned list.
> Reference:
> GcsUtil.java has similar implementation in makeCopyBatches() and
> executeBatches().
> https://github.com/apache/beam/blob/master/sdks/java/core/src/main/java/org/apache/beam/sdk/util/GcsUtil.java#L550
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
