[
https://issues.apache.org/jira/browse/BEAM-11832?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Minbo Bae updated BEAM-11832:
-----------------------------
Resolution: Fixed
Status: Resolved (was: Open)
> Time correction by NTP sync can skew metrics
> --------------------------------------------
>
> Key: BEAM-11832
> URL: https://issues.apache.org/jira/browse/BEAM-11832
> Project: Beam
> Issue Type: Bug
> Components: runner-dataflow
> Reporter: Minbo Bae
> Priority: P3
> Attachments: clock_correction.png
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> GCE VM time can be corrected by NTP sync. If this
> happens,`System.currentTimeMillis()` can set back to the past. You may see
> this [^clock_correction.png] in Cloud Logging for time correction.
> The rolled back clock can cause skewed metrics. For example,
> `ExecutionStateSampler` uses `System.currentTimeMillis` [1]. I guess we can
> mitigate this issue using `System.nanoTime` for elapsed times (maybe not
> perfect as per [2]).
> [1]
> [https://github.com/apache/beam/blob/v2.27.0/runners/core-java/src/main/java/org/apache/beam/runners/core/metrics/ExecutionStateSampler.java#L42]
> [2] [https://bugs.openjdk.java.net/browse/JDK-6458294]
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
