[
https://issues.apache.org/jira/browse/BEAM-13544?focusedWorklogId=707376&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-707376
]
ASF GitHub Bot logged work on BEAM-13544:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 12/Jan/22 10:01
Start Date: 12/Jan/22 10:01
Worklog Time Spent: 10m
Work Description: KhaninArtur commented on a change in pull request
#16486:
URL: https://github.com/apache/beam/pull/16486#discussion_r782903826
##########
File path: playground/infrastructure/cd_helper.py
##########
@@ -26,8 +26,10 @@
from pathlib import Path
from typing import List
+import tqdm
Review comment:
Could you please add the `tqdm` package to the requirements file?
##########
File path: playground/infrastructure/cd_helper.py
##########
@@ -82,11 +89,14 @@ def _save_to_cloud_storage(self, examples: List[Example]):
"""
self._storage_client = storage.Client()
self._bucket = self._storage_client.bucket(Config.BUCKET_NAME)
+ pbar = tqdm(total=len(examples))
for example in examples:
Review comment:
If I'm not mistaken, you can do just this:
```suggestion
for example in tqdm(examples):
```
And then you don't need to do `pbar.update` and `pbar.close` at the end.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 707376)
Time Spent: 50m (was: 40m)
> [Playground] Add logs to examples CI/CD to see the progress
> -----------------------------------------------------------
>
> Key: BEAM-13544
> URL: https://issues.apache.org/jira/browse/BEAM-13544
> Project: Beam
> Issue Type: Improvement
> Components: beam-playground
> Reporter: Artur Khanin
> Assignee: Aydar Zaynutdinov
> Priority: P2
> Labels: beam-playground-backend, beam-playground-sprint-7
> Time Spent: 50m
> Remaining Estimate: 0h
>
> As a Beam Playground {*}Contributor{*}, I want to see and clearly understand
> how many tagged examples are found and how many of them are processed during
> the check of a new PR.
> {*}Acceptance criteria{*}:
> * During the examples validation step need to print logs about how much
> files found and processed
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
