[
https://issues.apache.org/jira/browse/BEAM-4610?focusedWorklogId=220087&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-220087
]
ASF GitHub Bot logged work on BEAM-4610:
----------------------------------------
Author: ASF GitHub Bot
Created on: 28/Mar/19 15:55
Start Date: 28/Mar/19 15:55
Worklog Time Spent: 10m
Work Description: iemejia commented on pull request #8161: [BEAM-4610]
Add SSL support for RedisIO
URL: https://github.com/apache/beam/pull/8161#discussion_r270071514
##########
File path:
sdks/java/io/redis/src/main/java/org/apache/beam/sdk/io/redis/RedisConnectionConfiguration.java
##########
@@ -99,9 +105,18 @@ public RedisConnectionConfiguration withTimeout(int
timeout) {
return builder().setTimeout(timeout).build();
}
+ /**
+ * Enable SSL connection to Redis server.
Review comment:
nit: remove the @return part and inline like the other methods
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 220087)
Time Spent: 0.5h (was: 20m)
> RedisIO should allow to configure SSL
> -------------------------------------
>
> Key: BEAM-4610
> URL: https://issues.apache.org/jira/browse/BEAM-4610
> Project: Beam
> Issue Type: Improvement
> Components: io-java-redis
> Reporter: Ismaël Mejía
> Assignee: LI Guobao
> Priority: Minor
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> Current version of RedisIO does not support SSL connection, this could be
> easily added by enabling the flag as a configuration option in the IO.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
