[
https://issues.apache.org/jira/browse/BEAM-13616?focusedWorklogId=707801&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-707801
]
ASF GitHub Bot logged work on BEAM-13616:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 12/Jan/22 18:57
Start Date: 12/Jan/22 18:57
Worklog Time Spent: 10m
Work Description: TheNeuralBit commented on a change in pull request
#16473:
URL: https://github.com/apache/beam/pull/16473#discussion_r783355502
##########
File path: vendor/README.md
##########
@@ -78,3 +79,38 @@ references to the missing classes. Here are the known
linkage errors:
to be included in the vendored artifact. Slf4j-api is available at Beam's
runtime.
- References to `reactor.blockhound`: When enabled, Netty's BlockHound
integration can detect
unexpected blocking calls. Beam does not use it.
+
+## Create testing PR against new artifacts
+
+Once you've verified using the linkage tool, you can test new artifacts by
running unit and integration tests against a PR.
+
+Example PRs:
+- Updating gRPC version (large) https://github.com/apache/beam/pull/16460
+- Updating protobuf for calcite (minor version update):
https://github.com/apache/beam/pull/16476
+
+Steps:
+
+1. Generate new artifact files with `publishMavenJavaPublicationToMavenLocal`,
e.g.
+
+```
+./gradlew -p vendor/grpc-1_43_2 publishMavenJavaPublicationToMavenLocal
-Ppublishing -PvendoredDependenciesOnly
+
+# Copy files (jar/poms/metadata) to your beam repository
+cp -R ~/.m2/repository/org/apache/beam/beam-vendor-grpc-1_43_2/ \
+ $BEAMDIR/tempLib/org/apache/beam/beam-vendor-grpc-1_43_2
+```
+
+2. Add whatever folder (here I use `tempLib`) to the expected project
repositories, e.g.
+
+```
+repositories {
+ maven { url "${project.rootDir}/tempLib" }
+ maven {
+ ...
+ }
+}
+```
+
+3. Migrate all references from the old dependency to the new dependency,
including imports if needed.
+
+4. Commit any added or changed files and create a PR (can be a draft, as you
will not merge this PR) to test on.
Review comment:
Thank you for documenting this!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 707801)
Time Spent: 8h (was: 7h 50m)
> Update protobuf-java to 3.19.2 and other vendored dependencies that use
> protobuf
> --------------------------------------------------------------------------------
>
> Key: BEAM-13616
> URL: https://issues.apache.org/jira/browse/BEAM-13616
> Project: Beam
> Issue Type: Bug
> Components: build-system
> Reporter: Emily Ye
> Assignee: Emily Ye
> Priority: P1
> Fix For: 2.36.0
>
> Time Spent: 8h
> Remaining Estimate: 0h
>
> [https://github.com/protocolbuffers/protobuf/security/advisories/GHSA-wrvw-hg22-4m67]
> requires us to update versions of vendored artifacts that use protobuf, and
> recommended version of protobuf in BeamModuleGroovy
>
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
