[
https://issues.apache.org/jira/browse/BEAM-2939?focusedWorklogId=220301&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-220301
]
ASF GitHub Bot logged work on BEAM-2939:
----------------------------------------
Author: ASF GitHub Bot
Created on: 28/Mar/19 23:07
Start Date: 28/Mar/19 23:07
Worklog Time Spent: 10m
Work Description: lukecwik commented on pull request #8088: [BEAM-2939]
SDF sizing in FnAPI and Python SDK/runner.
URL: https://github.com/apache/beam/pull/8088#discussion_r270229659
##########
File path: model/pipeline/src/main/proto/beam_runner_api.proto
##########
@@ -301,8 +301,15 @@ message StandardPTransforms {
// Like PROCESS_KEYED_ELEMENTS, but without the unique key - just elements
// and restrictions.
- // Input: KV(element, restriction); output: DoFn's output.
+ // Input: KV(KV(element, restriction), weight); output: DoFn's output.
PROCESS_ELEMENTS = 3 [(beam_urn) =
"beam:transform:sdf_process_elements:v1"];
Review comment:
Any reason you want to go with "weights" instead of "sizes" since you use
the term size in the code below?
You should keep this URN as is and define a new URN
"beam:transform:sdf_process_elements_with_sizes/weights:v1"
Drop "size restrictions" and instead add
"beam:transform:sdf_split_restrictions_with_sizes/weights:v1"
You'll need to add a new well known coder for IEEE 754 doubles to represent
"sizes/weights"
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 220301)
Time Spent: 14h (was: 13h 50m)
> Fn API streaming SDF support
> ----------------------------
>
> Key: BEAM-2939
> URL: https://issues.apache.org/jira/browse/BEAM-2939
> Project: Beam
> Issue Type: Improvement
> Components: beam-model
> Reporter: Henning Rohde
> Assignee: Luke Cwik
> Priority: Major
> Labels: portability, triaged
> Time Spent: 14h
> Remaining Estimate: 0h
>
> The Fn API should support streaming SDF. Detailed design TBD.
> Once design is ready, expand subtasks similarly to BEAM-2822.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
