[
https://issues.apache.org/jira/browse/BEAM-13407?focusedWorklogId=708861&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-708861
]
ASF GitHub Bot logged work on BEAM-13407:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 14/Jan/22 04:34
Start Date: 14/Jan/22 04:34
Worklog Time Spent: 10m
Work Description: aaltay commented on pull request #16322:
URL: https://github.com/apache/beam/pull/16322#issuecomment-1012745873
Looking at the relevant files:
Roboto: I do not believe you have to do anything related to this. It is a
standard Apache License, and there is no NOTICE file
(https://github.com/googlefonts/roboto). It is fine to include this according
to https://apache.org/legal/resolved.html#category-a
Source Code Pro and Source Sans Pro - Technically the instance of the
playground will be allow downloads of these files and will be a binary
distribution. Because of that you need to include the licenses. Standard
solution would be to append this to
https://github.com/apache/beam/blob/master/LICENSE (note that this is all under
A part of several convenience binary distributions of this software is licensed
as follows:) AND link to https://github.com/apache/beam/blob/master/LICENSE
from the playground website.
Also note that the notice about "Do not include Category B licensed works in
source releases." (https://apache.org/legal/resolved.html#category-b). Our
release process zips up the whole repo and distributes it as a source
distribution. In other to follow the ASF guidance the release toolings needs to
be updated to remove the references to these fonts in the source distribution.
My suggestion would be:
- Not to use use these fonts and use only category A licensed fonts
- OR hot link to the fonts by the links provided from
(https://fonts.google.com/specimen/Source+Sans+Pro#standard-styles) e.g.
```
<link rel="preconnect" href="https://fonts.googleapis.com";>
<link rel="preconnect" href="https://fonts.gstatic.com"; crossorigin>
<link
href="https://fonts.googleapis.com/css2?family=Source+Sans+Pro:ital,wght@1,200&display=swap";
rel="stylesheet">
```
or
```
<style>
@import
url('https://fonts.googleapis.com/css2?family=Source+Sans+Pro:ital,wght@1,200&display=swap');
</style>
```
This would also give us the benefit of using the CDN for fonts.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 708861)
Time Spent: 2h 40m (was: 2.5h)
> [Playground] Preload fonts for the web application
> --------------------------------------------------
>
> Key: BEAM-13407
> URL: https://issues.apache.org/jira/browse/BEAM-13407
> Project: Beam
> Issue Type: Sub-task
> Components: beam-playground
> Reporter: Aydar Farrakhov
> Assignee: Alexander Zhuravlev
> Priority: P3
> Labels: beam-playground-frontend
> Time Spent: 2h 40m
> Remaining Estimate: 0h
>
> Currently, we are loading fonts from google. We need to preload them using
> the next instruction:
> https://pub.dev/packages/google_fonts#bundling-font-files-in-your-applications-assets
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
