[
https://issues.apache.org/jira/browse/BEAM-13429?focusedWorklogId=708888&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-708888
]
ASF GitHub Bot logged work on BEAM-13429:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 14/Jan/22 06:40
Start Date: 14/Jan/22 06:40
Worklog Time Spent: 10m
Work Description: KhaninArtur commented on a change in pull request
#16482:
URL: https://github.com/apache/beam/pull/16482#discussion_r784550816
##########
File path: playground/backend/internal/preparers/java_preparers.go
##########
@@ -119,11 +143,6 @@ func replace(args ...interface{}) error {
}
func removePublicClassModifier(args ...interface{}) error {
- validationResults := args[3].(*sync.Map)
- isUnitTest, ok :=
validationResults.Load(validators.UnitTestValidatorName)
- if ok && isUnitTest.(bool) {
- return nil
- }
err := replace(args...)
return err
}
Review comment:
Here we also can directly use `replace`, can you please remove this
function?
##########
File path: playground/backend/internal/utils/preparators_utils.go
##########
@@ -17,25 +17,35 @@ package utils
Review comment:
Can we also rename this file to `preparers_utils.go`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 708888)
Time Spent: 2h 10m (was: 2h)
> [Playground] Improve preparators by the introducing of builder
> ---------------------------------------------------------------
>
> Key: BEAM-13429
> URL: https://issues.apache.org/jira/browse/BEAM-13429
> Project: Beam
> Issue Type: Improvement
> Components: beam-playground
> Reporter: Daria Malkova
> Assignee: Daria Malkova
> Priority: P3
> Labels: beam-playground-backend, beam-playground-sprint-6,
> beam-playground-sprint-7
> Time Spent: 2h 10m
> Remaining Estimate: 0h
>
> Investigate and implement (if need) a usage of a builder for preparators to
> construct the necessary builders for each SDK/unit-test/not-unit-test
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
