[ 
https://issues.apache.org/jira/browse/BEAM-13665?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17476339#comment-17476339
 ] 

Kenneth Knowles commented on BEAM-13665:
----------------------------------------

Taking a look at the commit, I think it affects only back to 2.34.0. It is 
worth getting into 2.36.0 since we probably have many users who will upgrade 
right past those two versions.

> Spanner IO request metrics requires projectId within the config when it 
> didn't in the past
> ------------------------------------------------------------------------------------------
>
>                 Key: BEAM-13665
>                 URL: https://issues.apache.org/jira/browse/BEAM-13665
>             Project: Beam
>          Issue Type: Bug
>          Components: io-java-gcp
>    Affects Versions: 2.34.0, 2.35.0
>            Reporter: Luke Cwik
>            Priority: P1
>             Fix For: 2.36.0
>
>
> https://github.com/apache/beam/pull/15493 makes the GCP projectID a required 
> parameter - which it was not before, as it could be inferred from the 
> environment - and thus breaks backward compatibility.
> Specifically: BatchSpannerRead.java:175 -- the toString() is not required on 
> the valueProvider, it should just be a get(), and createServiceCallMetric() 
> in line 195 should handle the situation where projectID could be null



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

Reply via email to