[
https://issues.apache.org/jira/browse/BEAM-13650?focusedWorklogId=709880&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-709880
]
ASF GitHub Bot logged work on BEAM-13650:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 17/Jan/22 11:50
Start Date: 17/Jan/22 11:50
Worklog Time Spent: 10m
Work Description: ilya-kozyrev commented on a change in pull request
#16502:
URL: https://github.com/apache/beam/pull/16502#discussion_r785906696
##########
File path: playground/infrastructure/helper.py
##########
@@ -240,6 +241,7 @@ def _get_example(
with open(filepath, encoding="utf-8") as parsed_file:
content = parsed_file.read()
content = content.replace(tag.tag_as_string, "")
+ link = Config.LINK_PREFIX + (filepath.replace(os.getenv("BEAM_ROOT_DIR"),
"", 1))
Review comment:
Please use string formating instead of concatenation
##########
File path: playground/infrastructure/helper.py
##########
@@ -61,6 +61,7 @@ class Example:
type: PrecompiledObjectType = PRECOMPILED_OBJECT_TYPE_UNSPECIFIED
pipeline_id: str = ""
output: str = ""
+ link: str = ""
Review comment:
Might it be optional?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 709880)
Time Spent: 0.5h (was: 20m)
> [Playground] Add link for examples
> ----------------------------------
>
> Key: BEAM-13650
> URL: https://issues.apache.org/jira/browse/BEAM-13650
> Project: Beam
> Issue Type: Sub-task
> Components: beam-playground
> Reporter: Aydar Zaynutdinov
> Assignee: Aydar Zaynutdinov
> Priority: P3
> Labels: beam-playground-backend
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> Add a field _link_ for the example on the searching examples step for the
> CI/CD step. This field contains a link to the example file in the beam repo
> and must be sent to the bucket.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
