[ 
https://issues.apache.org/jira/browse/BEAM-10838?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17478796#comment-17478796
 ] 

Evan Galpin commented on BEAM-10838:
------------------------------------

I'm +1 as well.  Looks like we could probably overload or refactor 
`ConnectionConfiguration#createClient`[1] to handle this. With that in mind, 
I'm inclined to say that the new method proposed by Conor should be added to 
the ConnectionConfiguration builder, so that 
`ConnectionConfiguration#createClient` can continue to be called without 
arguments to produce a valid RestClient i.e. ConnectionConfiguration should own 
the SSLContextBuilder in my opinion.

[~clandry94] This would be a welcome addition!


[1] 
https://github.com/apache/beam/blob/master/sdks/java/io/elasticsearch/src/main/java/org/apache/beam/sdk/io/elasticsearch/ElasticsearchIO.java#L621-L622

> Add a withSSLContext builder method to ElasticsearchIO 
> -------------------------------------------------------
>
>                 Key: BEAM-10838
>                 URL: https://issues.apache.org/jira/browse/BEAM-10838
>             Project: Beam
>          Issue Type: New Feature
>          Components: io-java-elasticsearch
>            Reporter: Conor Landry
>            Priority: P2
>
> Currently, the ElasticsearchIO transforms only one way to securely read/write 
> Elasticsearch by using the withKeystorePath builder method and providing the 
> location of a keystore containing a client key in jks format. 
> This is a bit limiting, especially for Elasticsearch users not depending on 
> shield to secure their clusters. I'd like to propose the addition of the 
> builder method withSSLContext(SSLContext sslContext, which delegates to 
> `httpClientBuilder.setSSLContext`. 
> If this is (y), I can start working on it.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

Reply via email to