[
https://issues.apache.org/jira/browse/BEAM-9191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17478891#comment-17478891
]
Kyle Weaver commented on BEAM-9191:
-----------------------------------
The attached PR did not fix the issue. There are still ignored tests that link
to this bug.
> CAST does not work in some cases due to bugs in Calcite unparsing
> -----------------------------------------------------------------
>
> Key: BEAM-9191
> URL: https://issues.apache.org/jira/browse/BEAM-9191
> Project: Beam
> Issue Type: Improvement
> Components: dsl-sql-zetasql
> Reporter: Robin Qiu
> Priority: P3
> Labels: beam-fixit
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> For example:
> "CAST(xxx AS TIMESTAMP)" is unparsed to "CAST(xxx AS TIMESTAMP(0))"
> The fix is already in the newest version of BigQuerySqlDialect.java in
> Calcite (using
> [SqlAlienSystemTypeNameSpec|https://github.com/apache/calcite/blob/3621b61ea0bca953652a2e6d1838e5a296c6a007/core/src/main/java/org/apache/calcite/sql/dialect/BigQuerySqlDialect.java#L293]),
> so this issue will be fixed after we update our vendored Calcite version.
> I tried to patch the change to BeamBigQuerySqlDialect.java (similar to what
> we did for other features) but this change is very large (multiple new
> classes) to patch.
> cc: [~apilloud]
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
