[
https://issues.apache.org/jira/browse/BEAM-13685?focusedWorklogId=711677&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-711677
]
ASF GitHub Bot logged work on BEAM-13685:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 19/Jan/22 21:29
Start Date: 19/Jan/22 21:29
Worklog Time Spent: 10m
Work Description: KevinGG commented on a change in pull request #16555:
URL: https://github.com/apache/beam/pull/16555#discussion_r788154044
##########
File path: sdks/python/apache_beam/runners/interactive/cache_manager_test.py
##########
@@ -215,6 +215,21 @@ def test_load_saved_pcoder(self):
type(self.cache_manager.load_pcoder('full', 'a key')),
type(coders.registry.get_coder(int)))
+ def test_cache_manager_uses_ib_specified_cache_dir(self):
Review comment:
Could you please add an additional test for both cache manager
implementations when the cache dir is explicitly set to a local file path?
For example, "/tmp/it-test/", then you can actually verify if a cache dir
and additional cache files are created by creating a pipeline with interactive
runner and call ib.collect.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 711677)
Time Spent: 3h 20m (was: 3h 10m)
> Enable users to specify cache directory under Interactive Beam options
> ----------------------------------------------------------------------
>
> Key: BEAM-13685
> URL: https://issues.apache.org/jira/browse/BEAM-13685
> Project: Beam
> Issue Type: Task
> Components: runner-py-interactive
> Reporter: Victor Chen
> Assignee: Victor Chen
> Priority: P2
> Time Spent: 3h 20m
> Remaining Estimate: 0h
>
> - Adds specified_cache_dir option under interactive_beam.py and
> interactive_options.py
> - Integrates new specified_cache_dir from interactive_beam.py into
> cache_manager.py and streaming_cache.py
> - Includes unit tests under cache_manager_test.py and streaming_cache_test.py
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
