[
https://issues.apache.org/jira/browse/BEAM-13699?focusedWorklogId=711846&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-711846
]
ASF GitHub Bot logged work on BEAM-13699:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 20/Jan/22 03:08
Start Date: 20/Jan/22 03:08
Worklog Time Spent: 10m
Work Description: codecov[bot] commented on pull request #16573:
URL: https://github.com/apache/beam/pull/16573#issuecomment-1017075275
#
[Codecov](https://codecov.io/gh/apache/beam/pull/16573?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
Report
> Merging
[#16573](https://codecov.io/gh/apache/beam/pull/16573?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
(c40e55a) into
[master](https://codecov.io/gh/apache/beam/commit/f31cad083986836e03bc1305d56efc969f20630a?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
(f31cad0) will **not change** coverage.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/beam/pull/16573?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #16573 +/- ##
=======================================
Coverage 46.32% 46.32%
=======================================
Files 201 201
Lines 19734 19734
=======================================
Hits 9141 9141
Misses 9612 9612
Partials 981 981
```
| [Impacted
Files](https://codecov.io/gh/apache/beam/pull/16573?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
| Coverage Δ | |
|---|---|---|
|
[sdks/go/pkg/beam/core/runtime/exec/hash.go](https://codecov.io/gh/apache/beam/pull/16573/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9nby9wa2cvYmVhbS9jb3JlL3J1bnRpbWUvZXhlYy9oYXNoLmdv)
| `34.95% <100.00%> (ø)` | |
------
[Continue to review full report at
Codecov](https://codecov.io/gh/apache/beam/pull/16573?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn
more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by
[Codecov](https://codecov.io/gh/apache/beam/pull/16573?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
Last update
[f31cad0...c40e55a](https://codecov.io/gh/apache/beam/pull/16573?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
Read the [comment
docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 711846)
Time Spent: 0.5h (was: 20m)
> [Go SDK] Change Combiner Lifting hash to maphash.
> -------------------------------------------------
>
> Key: BEAM-13699
> URL: https://issues.apache.org/jira/browse/BEAM-13699
> Project: Beam
> Issue Type: Improvement
> Components: sdk-go
> Reporter: Robert Burke
> Priority: P2
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> https://pkg.go.dev/hash/maphash is actually intended for use as a hashtable
> hash, and leverages the go runtime's efficient map hasher. This will
> hopefully lead to a mild speedup, and with the additional random seeds
> (consistent for the life of a hasher) will reduce the odds of collisions vs
> the current deterministic hasher.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
