[
https://issues.apache.org/jira/browse/BEAM-13558?focusedWorklogId=712160&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-712160
]
ASF GitHub Bot logged work on BEAM-13558:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 20/Jan/22 16:10
Start Date: 20/Jan/22 16:10
Worklog Time Spent: 10m
Work Description: damondouglas commented on a change in pull request
#16369:
URL: https://github.com/apache/beam/pull/16369#discussion_r788918953
##########
File path: playground/frontend/lib/modules/output/components/output.dart
##########
@@ -33,7 +33,7 @@ class _OutputState extends State<Output> with
SingleTickerProviderStateMixin {
@override
void initState() {
- tabController = TabController(vsync: this, length: 3);
+ tabController = TabController(vsync: this, length: 2);
Review comment:
@miamihotline This comment is not a blocker for this PR but in the
future I propose instead of hardcoding the number of tabs in the TabController,
having a final variable that is an array of OutputTab widgets and using this
variable to assign its length to the TabController length property and
assigning this array to the tabs property of the TabBar widget. This way one
could add or remove widgets in the TabBar tabs property and never have to
remember to also change this number.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 712160)
Time Spent: 0.5h (was: 20m)
> [Playground] Hide the Graph tab and SCIO from SDK options
> ---------------------------------------------------------
>
> Key: BEAM-13558
> URL: https://issues.apache.org/jira/browse/BEAM-13558
> Project: Beam
> Issue Type: Task
> Components: beam-playground
> Reporter: Artur Khanin
> Assignee: Alexander Zhuravlev
> Priority: P2
> Labels: beam-playground-frontend, beam-playground-sprint-6
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> The Graph tab and SCIO from SDK options need to be hidden until we support
> these features.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
