[ 
https://issues.apache.org/jira/browse/BEAM-13687?focusedWorklogId=713056&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-713056
 ]

ASF GitHub Bot logged work on BEAM-13687:
-----------------------------------------

                Author: ASF GitHub Bot
            Created on: 21/Jan/22 20:07
            Start Date: 21/Jan/22 20:07
    Worklog Time Spent: 10m 
      Work Description: nielm commented on pull request #16580:
URL: https://github.com/apache/beam/pull/16580#issuecomment-1018822837


   LGTM


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Issue Time Tracking
-------------------

    Worklog Id:     (was: 713056)
    Time Spent: 0.5h  (was: 20m)

> Java Spanner - Improve IO Request Count metrics
> -----------------------------------------------
>
>                 Key: BEAM-13687
>                 URL: https://issues.apache.org/jira/browse/BEAM-13687
>             Project: Beam
>          Issue Type: Improvement
>          Components: io-java-gcp
>            Reporter: Niel Markwick
>            Assignee: Ning
>            Priority: P2
>             Fix For: 2.34.0
>
>          Time Spent: 0.5h
>  Remaining Estimate: 0h
>
> Request count metrics are created in the ProcessElement function for 
> SpannerIO Reads and Writes: 
> [BatchSpannerRead.java#L173|https://github.com/nielm/beam/blob/master/sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/spanner/BatchSpannerRead.java#L173]
> [SpannerIO.java#L1681|https://github.com/nielm/beam/blob/master/sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/spanner/SpannerIO.java#L1681]
>  
> This could cause a performance regression
> (ref https://issues.apache.org/jira/browse/BEAM-13665
> [https://github.com/apache/beam/pull/16547] )



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

Reply via email to