[
https://issues.apache.org/jira/browse/BEAM-6588?focusedWorklogId=221312&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-221312
]
ASF GitHub Bot logged work on BEAM-6588:
----------------------------------------
Author: ASF GitHub Bot
Created on: 01/Apr/19 14:44
Start Date: 01/Apr/19 14:44
Worklog Time Spent: 10m
Work Description: robertwb commented on pull request #8185: [BEAM-6588]
Fix type hints for beam.Filter
URL: https://github.com/apache/beam/pull/8185
------------------------
Thank you for your contribution! Follow this checklist to help us
incorporate your contribution quickly and easily:
- [ ] [**Choose
reviewer(s)**](https://beam.apache.org/contribute/#make-your-change) and
mention them in a comment (`R: @username`).
- [ ] Format the pull request title like `[BEAM-XXX] Fixes bug in
ApproximateQuantiles`, where you replace `BEAM-XXX` with the appropriate JIRA
issue, if applicable. This will automatically link the pull request to the
issue.
- [ ] If this contribution is large, please file an Apache [Individual
Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
Post-Commit Tests Status (on master branch)
------------------------------------------------------------------------------------------------
Lang | SDK | Apex | Dataflow | Flink | Gearpump | Samza | Spark
--- | --- | --- | --- | --- | --- | --- | ---
Go | [](https://builds.apache.org/job/beam_PostCommit_Go/lastCompletedBuild/)
| --- | --- | --- | --- | --- | ---
Java | [](https://builds.apache.org/job/beam_PostCommit_Java/lastCompletedBuild/)
| [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Apex/lastCompletedBuild/)
| [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Dataflow/lastCompletedBuild/)
| [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Flink/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Java_PVR_Flink_Batch/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Java_PVR_Flink_Streaming/lastCompletedBuild/)
| [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Gearpump/lastCompletedBuild/)
| [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Samza/lastCompletedBuild/)
| [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Spark/lastCompletedBuild/)
Python | [](https://builds.apache.org/job/beam_PostCommit_Python_Verify/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Python3_Verify/lastCompletedBuild/)
| --- | [](https://builds.apache.org/job/beam_PostCommit_Py_VR_Dataflow/lastCompletedBuild/)
<br> [](https://builds.apache.org/job/beam_PostCommit_Py_ValCont/lastCompletedBuild/)
| [](https://builds.apache.org/job/beam_PreCommit_Python_PVR_Flink_Cron/lastCompletedBuild/)
| --- | --- | ---
Pre-Commit Tests Status (on master branch)
------------------------------------------------------------------------------------------------
--- |Java | Python | Go | Website
--- | --- | --- | --- | ---
Non-portable | [](https://builds.apache.org/job/beam_PreCommit_Java_Cron/lastCompletedBuild/)
| [](https://builds.apache.org/job/beam_PreCommit_Python_Cron/lastCompletedBuild/)
| [](https://builds.apache.org/job/beam_PreCommit_Go_Cron/lastCompletedBuild/)
| [](https://builds.apache.org/job/beam_PreCommit_Website_Cron/lastCompletedBuild/)
Portable | --- | [](https://builds.apache.org/job/beam_PreCommit_Portable_Python_Cron/lastCompletedBuild/)
| --- | ---
See
[.test-infra/jenkins/README](https://github.com/apache/beam/blob/master/.test-infra/jenkins/README.md)
for trigger phrase, status and link of all Jenkins jobs.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 221312)
Time Spent: 10m
Remaining Estimate: 0h
> Error in inferring output typehints for beam.Filter
> ---------------------------------------------------
>
> Key: BEAM-6588
> URL: https://issues.apache.org/jira/browse/BEAM-6588
> Project: Beam
> Issue Type: New Feature
> Components: sdk-py-core
> Reporter: Robert Bradshaw
> Assignee: Ahmet Altay
> Priority: Major
> Labels: triaged
> Time Spent: 10m
> Remaining Estimate: 0h
>
> If a type hint is specified for an input to beam.Filter, it attempts to infer
> the output type (as Iterable[input_type], consistent with FlatMap), but that
> inference appears to have a bug in it.
> With the code:
> {code:python}
> @beam.typehints.with_input_types(int)
> def OddFilter(data):
> return data % 2 == 0
> def pipeline(root):
> base = root | beam.Create(xrange(100))
> next = base | beam.Filter(OddFilter)
> {code}
> The following error is returned:
> {code:python}
> File "/google3/experimental/testproj/test_beam.py", line 26, in pipeline
> next = base | beam.Filter(OddFilter)
> File "/google3/third_party/py/apache_beam/transforms/core.py", line 1147,
> in Filter
> get_type_hints(wrapper).set_output_types(typehints.Iterable[output_hint])
> File "/google3/third_party/py/apache_beam/typehints/typehints.py", line
> 951, in __getitem__
> type_param, error_msg_prefix='Parameter to an Iterable hint'
> File "/google3/third_party/py/apache_beam/typehints/typehints.py", line
> 359, in validate_composite_type_param
> type_param.__class__.__name__))
> TypeError: Parameter to an Iterable hint must be a non-sequence, a type, or a
> TypeConstraint. (<type 'int'>,) is an instance of tuple.
> {code}
> Explicitly specifying the output type (as beam.typehints.Iterable[int]) works
> fine. The code in core.py seems to be correct, but I'm guessing it needs a
> derefence of the tuple to actually extract the type:
> http://google3/third_party/py/apache_beam/transforms/core.py?l=1145&rcl=228573657
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
