[
https://issues.apache.org/jira/browse/BEAM-13595?focusedWorklogId=713864&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-713864
]
ASF GitHub Bot logged work on BEAM-13595:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 24/Jan/22 15:57
Start Date: 24/Jan/22 15:57
Worklog Time Spent: 10m
Work Description: codecov[bot] edited a comment on pull request #16589:
URL: https://github.com/apache/beam/pull/16589#issuecomment-1018921582
#
[Codecov](https://codecov.io/gh/apache/beam/pull/16589?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
Report
> Merging
[#16589](https://codecov.io/gh/apache/beam/pull/16589?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
(5eb27c7) into
[master](https://codecov.io/gh/apache/beam/commit/737be255d874af17f3cbf40f7c03fc66b3896b13?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
(737be25) will **increase** coverage by `8.97%`.
> The diff coverage is `53.33%`.
[](https://codecov.io/gh/apache/beam/pull/16589?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #16589 +/- ##
==========================================
+ Coverage 74.63% 83.61% +8.97%
==========================================
Files 653 452 -201
Lines 81825 62095 -19730
==========================================
- Hits 61070 51920 -9150
+ Misses 19774 10175 -9599
+ Partials 981 0 -981
```
| [Impacted
Files](https://codecov.io/gh/apache/beam/pull/16589?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
| Coverage Δ | |
|---|---|---|
|
[...dks/python/apache\_beam/options/pipeline\_options.py](https://codecov.io/gh/apache/beam/pull/16589/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vb3B0aW9ucy9waXBlbGluZV9vcHRpb25zLnB5)
| `95.27% <ø> (ø)` | |
|
[...thon/apache\_beam/runners/worker/sdk\_worker\_main.py](https://codecov.io/gh/apache/beam/pull/16589/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy93b3JrZXIvc2RrX3dvcmtlcl9tYWluLnB5)
| `73.22% <41.66%> (+0.42%)` | :arrow_up: |
|
[...s/python/apache\_beam/runners/portability/stager.py](https://codecov.io/gh/apache/beam/pull/16589/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9wb3J0YWJpbGl0eS9zdGFnZXIucHk=)
| `88.36% <100.00%> (+0.07%)` | :arrow_up: |
|
[...ks/python/apache\_beam/runners/worker/data\_plane.py](https://codecov.io/gh/apache/beam/pull/16589/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy93b3JrZXIvZGF0YV9wbGFuZS5weQ==)
| `87.50% <0.00%> (-1.71%)` | :arrow_down: |
|
[sdks/python/apache\_beam/internal/metrics/metric.py](https://codecov.io/gh/apache/beam/pull/16589/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW50ZXJuYWwvbWV0cmljcy9tZXRyaWMucHk=)
| `90.00% <0.00%> (-1.00%)` | :arrow_down: |
|
[...pache\_beam/runners/interactive/interactive\_beam.py](https://codecov.io/gh/apache/beam/pull/16589/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9pbnRlcmFjdGl2ZS9pbnRlcmFjdGl2ZV9iZWFtLnB5)
| `76.41% <0.00%> (-0.95%)` | :arrow_down: |
|
[...runners/interactive/display/pcoll\_visualization.py](https://codecov.io/gh/apache/beam/pull/16589/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9pbnRlcmFjdGl2ZS9kaXNwbGF5L3Bjb2xsX3Zpc3VhbGl6YXRpb24ucHk=)
| `85.85% <0.00%> (-0.51%)` | :arrow_down: |
|
[...nners/portability/fn\_api\_runner/worker\_handlers.py](https://codecov.io/gh/apache/beam/pull/16589/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9wb3J0YWJpbGl0eS9mbl9hcGlfcnVubmVyL3dvcmtlcl9oYW5kbGVycy5weQ==)
| `79.44% <0.00%> (-0.35%)` | :arrow_down: |
|
[...hon/apache\_beam/runners/worker/bundle\_processor.py](https://codecov.io/gh/apache/beam/pull/16589/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy93b3JrZXIvYnVuZGxlX3Byb2Nlc3Nvci5weQ==)
| `93.51% <0.00%> (-0.13%)` | :arrow_down: |
|
[sdks/go/pkg/beam/transforms/stats/mean.go](https://codecov.io/gh/apache/beam/pull/16589/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9nby9wa2cvYmVhbS90cmFuc2Zvcm1zL3N0YXRzL21lYW4uZ28=)
| | |
| ... and [200
more](https://codecov.io/gh/apache/beam/pull/16589/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
| |
------
[Continue to review full report at
Codecov](https://codecov.io/gh/apache/beam/pull/16589?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn
more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by
[Codecov](https://codecov.io/gh/apache/beam/pull/16589?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
Last update
[737be25...5eb27c7](https://codecov.io/gh/apache/beam/pull/16589?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
Read the [comment
docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 713864)
Time Spent: 2h 10m (was: 2h)
> Disable save_main_session when using cloudpickle
> ------------------------------------------------
>
> Key: BEAM-13595
> URL: https://issues.apache.org/jira/browse/BEAM-13595
> Project: Beam
> Issue Type: New Feature
> Components: sdk-py-core
> Reporter: Ryan Thompson
> Assignee: Anand Inguva
> Priority: P3
> Time Spent: 2h 10m
> Remaining Estimate: 0h
>
> [save_main_session|https://github.com/apache/beam/blob/17b62ad9e050f80a88793457aee710ea4711d47b/sdks/python/apache_beam/options/pipeline_options.py#L1089]
> is a flag in the python sdk that is used by the dill library to save all
> classes/variables/lambas in memory.
>
> When the cloudpickle library is used, no session is saved (it is a no op).
> However, if the runner sees the save_main_session option set it may try to
> access/move/manager the save_main_session saved file.
>
> To avoid this, when cloudpickle is the main library save_main_session should
> be false.
>
> See also:
> https://issues.apache.org/jira/browse/BEAM-13386
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
