[
https://issues.apache.org/jira/browse/BEAM-13247?focusedWorklogId=714474&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-714474
]
ASF GitHub Bot logged work on BEAM-13247:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 25/Jan/22 13:45
Start Date: 25/Jan/22 13:45
Worklog Time Spent: 10m
Work Description: ElessarST commented on a change in pull request #16606:
URL: https://github.com/apache/beam/pull/16606#discussion_r791724383
##########
File path:
playground/frontend/lib/modules/output/components/output_header/output_header.dart
##########
@@ -43,7 +45,7 @@ class OutputHeader extends StatelessWidget {
mainAxisAlignment: MainAxisAlignment.spaceBetween,
children: [
OutputTabs(tabController: tabController),
- const OutputPlacements(),
+ isEmbedded ? const SizedBox() : const OutputPlacements(),
Review comment:
same here, `showOutputPlacements`
##########
File path:
playground/frontend/lib/modules/editor/components/editor_textarea.dart
##########
@@ -82,7 +86,9 @@ class _EditorTextAreaState extends State<EditorTextArea> {
webSpaceFix: false,
);
- _setTextScrolling();
+ if (!widget.isEmbedded) {
Review comment:
Maybe it's better to rename it to the `enableScrolling`, so we can use
it in the future on other pages.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 714474)
Time Spent: 20m (was: 10m)
> [Playground] Embedding iframe
> -----------------------------
>
> Key: BEAM-13247
> URL: https://issues.apache.org/jira/browse/BEAM-13247
> Project: Beam
> Issue Type: New Feature
> Components: beam-playground
> Reporter: Artur Khanin
> Assignee: Alexander Zhuravlev
> Priority: P3
> Labels: beam-playground-frontend, beam-playground-sprint-7
> Time Spent: 20m
> Remaining Estimate: 0h
>
> As a Beam Playground {*}user{*}, I want to run code snippets directly from
> the [Apache Beam website|https://beam.apache.org/] without opening Beam
> Playground.
> *Acceptance criteria:*
> # The Beam Playground embedding is implemented.
> # The Beam Playground embedding may contain arbitrary code.
> # The Beam Playground embedding sends the code to run on the backend.
> # The Beam Playground embedding shows the output of the code it sent to run.
> Reference – https://pkg.go.dev/context#WithCancel
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
