[
https://issues.apache.org/jira/browse/BEAM-13736?focusedWorklogId=714690&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-714690
]
ASF GitHub Bot logged work on BEAM-13736:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 25/Jan/22 16:39
Start Date: 25/Jan/22 16:39
Worklog Time Spent: 10m
Work Description: codecov[bot] commented on pull request #16603:
URL: https://github.com/apache/beam/pull/16603#issuecomment-1020828161
#
[Codecov](https://codecov.io/gh/apache/beam/pull/16603?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
Report
> Merging
[#16603](https://codecov.io/gh/apache/beam/pull/16603?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
(6452ffe) into
[master](https://codecov.io/gh/apache/beam/commit/abac2df167480c335ee5a3181165d3e6a20cd037?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
(abac2df) will **increase** coverage by `0.12%`.
> The diff coverage is `80.28%`.
[](https://codecov.io/gh/apache/beam/pull/16603?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #16603 +/- ##
==========================================
+ Coverage 46.32% 46.44% +0.12%
==========================================
Files 201 201
Lines 19734 19785 +51
==========================================
+ Hits 9141 9189 +48
+ Misses 9612 9610 -2
- Partials 981 986 +5
```
| [Impacted
Files](https://codecov.io/gh/apache/beam/pull/16603?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
| Coverage Δ | |
|---|---|---|
|
[sdks/go/pkg/beam/core/runtime/exec/combine.go](https://codecov.io/gh/apache/beam/pull/16603/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9nby9wa2cvYmVhbS9jb3JlL3J1bnRpbWUvZXhlYy9jb21iaW5lLmdv)
| `62.73% <80.28%> (+6.08%)` | :arrow_up: |
------
[Continue to review full report at
Codecov](https://codecov.io/gh/apache/beam/pull/16603?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn
more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by
[Codecov](https://codecov.io/gh/apache/beam/pull/16603?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
Last update
[abac2df...6452ffe](https://codecov.io/gh/apache/beam/pull/16603?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
Read the [comment
docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 714690)
Time Spent: 1h (was: 50m)
> [Go SDK] Fix hash collision risk in Combiner Lifting cache
> ----------------------------------------------------------
>
> Key: BEAM-13736
> URL: https://issues.apache.org/jira/browse/BEAM-13736
> Project: Beam
> Issue Type: Improvement
> Components: sdk-go
> Reporter: Robert Burke
> Priority: P2
> Time Spent: 1h
> Remaining Estimate: 0h
>
> Relying only on a hash is brittle for map implementations, and can lead to
> correctness issues when keys collide.
> While the Go SDK implementation is leaning on the Go map, we need to rely on
> byte equality so we need to fend for ourselves a bit, and handle overflow
> buckets and the like.
> We won't go so far as to do a rehash or similar balancing techniques as it's
> not clear that between the caches' size constraint, and the evenness of the
> hash function that they are all that likely.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
