[ 
https://issues.apache.org/jira/browse/BEAM-13184?focusedWorklogId=715027&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-715027
 ]

ASF GitHub Bot logged work on BEAM-13184:
-----------------------------------------

                Author: ASF GitHub Bot
            Created on: 25/Jan/22 17:07
            Start Date: 25/Jan/22 17:07
    Worklog Time Spent: 10m 
      Work Description: calvin-orange commented on a change in pull request 
#15863:
URL: https://github.com/apache/beam/pull/15863#discussion_r791185003



##########
File path: 
sdks/java/io/jdbc/src/main/java/org/apache/beam/sdk/io/jdbc/JdbcIO.java
##########
@@ -2085,17 +2167,12 @@ private Connection getConnection() throws SQLException {
 
     @ProcessElement
     public void processElement(ProcessContext context) throws Exception {
-      T record = context.element();
-      records.add(record);
-      if (records.size() >= spec.getBatchSize()) {

Review comment:
       Great. Thank you!




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Issue Time Tracking
-------------------

    Worklog Id:     (was: 715027)
    Time Spent: 10h 10m  (was: 10h)

> Support autosharding for JdbcIO writers
> ---------------------------------------
>
>                 Key: BEAM-13184
>                 URL: https://issues.apache.org/jira/browse/BEAM-13184
>             Project: Beam
>          Issue Type: Improvement
>          Components: io-java-jdbc
>            Reporter: Pablo Estrada
>            Assignee: Pablo Estrada
>            Priority: P2
>             Fix For: 2.37.0
>
>          Time Spent: 10h 10m
>  Remaining Estimate: 0h
>
> This should improve efficiency for Jdbc writers on streaming pipelines



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

Reply via email to