[
https://issues.apache.org/jira/browse/BEAM-13271?focusedWorklogId=715379&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-715379
]
ASF GitHub Bot logged work on BEAM-13271:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 26/Jan/22 00:59
Start Date: 26/Jan/22 00:59
Worklog Time Spent: 10m
Work Description: codecov[bot] edited a comment on pull request #16231:
URL: https://github.com/apache/beam/pull/16231#issuecomment-993827704
#
[Codecov](https://codecov.io/gh/apache/beam/pull/16231?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
Report
> Merging
[#16231](https://codecov.io/gh/apache/beam/pull/16231?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
(f28daa6) into
[master](https://codecov.io/gh/apache/beam/commit/640e6c245a89581578da68b26d6e27b55deb6a80?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
(640e6c2) will **increase** coverage by `9.03%`.
> The diff coverage is `n/a`.
> :exclamation: Current head f28daa6 differs from pull request most recent
head 03b93ef. Consider uploading reports for the commit 03b93ef to get more
accurate results
[](https://codecov.io/gh/apache/beam/pull/16231?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #16231 +/- ##
==========================================
+ Coverage 74.63% 83.66% +9.03%
==========================================
Files 653 447 -206
Lines 81876 61692 -20184
==========================================
- Hits 61105 51616 -9489
+ Misses 19785 10076 -9709
+ Partials 986 0 -986
```
| [Impacted
Files](https://codecov.io/gh/apache/beam/pull/16231?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
| Coverage Δ | |
|---|---|---|
|
[sdks/python/apache\_beam/ml/gcp/cloud\_dlp.py](https://codecov.io/gh/apache/beam/pull/16231/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vbWwvZ2NwL2Nsb3VkX2RscC5weQ==)
| `58.33% <0.00%> (-16.14%)` | :arrow_down: |
|
[sdks/python/apache\_beam/typehints/row\_type.py](https://codecov.io/gh/apache/beam/pull/16231/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdHlwZWhpbnRzL3Jvd190eXBlLnB5)
| `84.21% <0.00%> (-5.27%)` | :arrow_down: |
|
[sdks/python/apache\_beam/utils/interactive\_utils.py](https://codecov.io/gh/apache/beam/pull/16231/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdXRpbHMvaW50ZXJhY3RpdmVfdXRpbHMucHk=)
| `90.24% <0.00%> (-4.88%)` | :arrow_down: |
|
[...thon/apache\_beam/io/aws/clients/s3/boto3\_client.py](https://codecov.io/gh/apache/beam/pull/16231/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW8vYXdzL2NsaWVudHMvczMvYm90bzNfY2xpZW50LnB5)
| `12.50% <0.00%> (-2.02%)` | :arrow_down: |
|
[sdks/python/apache\_beam/coders/row\_coder.py](https://codecov.io/gh/apache/beam/pull/16231/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vY29kZXJzL3Jvd19jb2Rlci5weQ==)
| `95.07% <0.00%> (-1.93%)` | :arrow_down: |
|
[...pache\_beam/runners/interactive/interactive\_beam.py](https://codecov.io/gh/apache/beam/pull/16231/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9pbnRlcmFjdGl2ZS9pbnRlcmFjdGl2ZV9iZWFtLnB5)
| `75.60% <0.00%> (-1.75%)` | :arrow_down: |
|
[...eam/runners/interactive/caching/streaming\_cache.py](https://codecov.io/gh/apache/beam/pull/16231/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9pbnRlcmFjdGl2ZS9jYWNoaW5nL3N0cmVhbWluZ19jYWNoZS5weQ==)
| `95.35% <0.00%> (-1.30%)` | :arrow_down: |
|
[...runners/interactive/options/interactive\_options.py](https://codecov.io/gh/apache/beam/pull/16231/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9pbnRlcmFjdGl2ZS9vcHRpb25zL2ludGVyYWN0aXZlX29wdGlvbnMucHk=)
| `85.71% <0.00%> (-0.96%)` | :arrow_down: |
|
[sdks/python/apache\_beam/io/gcp/bigquery.py](https://codecov.io/gh/apache/beam/pull/16231/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW8vZ2NwL2JpZ3F1ZXJ5LnB5)
| `62.85% <0.00%> (-0.74%)` | :arrow_down: |
|
[...runners/interactive/display/pcoll\_visualization.py](https://codecov.io/gh/apache/beam/pull/16231/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9pbnRlcmFjdGl2ZS9kaXNwbGF5L3Bjb2xsX3Zpc3VhbGl6YXRpb24ucHk=)
| `85.85% <0.00%> (-0.51%)` | :arrow_down: |
| ... and [257
more](https://codecov.io/gh/apache/beam/pull/16231/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
| |
------
[Continue to review full report at
Codecov](https://codecov.io/gh/apache/beam/pull/16231?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn
more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by
[Codecov](https://codecov.io/gh/apache/beam/pull/16231?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
Last update
[640e6c2...03b93ef](https://codecov.io/gh/apache/beam/pull/16231?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
Read the [comment
docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 715379)
Time Spent: 12h (was: 11h 50m)
> error-prone UnusedVariable check raises false positives for StateId and
> TimerId usages
> --------------------------------------------------------------------------------------
>
> Key: BEAM-13271
> URL: https://issues.apache.org/jira/browse/BEAM-13271
> Project: Beam
> Issue Type: Task
> Components: sdk-java-core
> Reporter: Brian Hulette
> Assignee: Brian Hulette
> Priority: P2
> Time Spent: 12h
> Remaining Estimate: 0h
>
> See https://github.com/google/error-prone/issues/2668. The next release of
> error-prone will contain https://github.com/google/error-prone/pull/2669 and
> https://github.com/google/error-prone/pull/2676, which will help us.
> Until then we've had to suppress the check in several places. This jira
> tracks upgrading to a new error-prone once released and removing the
> suppressions.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
