[
https://issues.apache.org/jira/browse/BEAM-13725?focusedWorklogId=715549&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-715549
]
ASF GitHub Bot logged work on BEAM-13725:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 26/Jan/22 09:38
Start Date: 26/Jan/22 09:38
Worklog Time Spent: 10m
Work Description: daria-malkova commented on a change in pull request
#16593:
URL: https://github.com/apache/beam/pull/16593#discussion_r792457376
##########
File path: playground/backend/cmd/server/controller.go
##########
@@ -309,3 +309,15 @@ func (controller *playgroundController)
GetPrecompiledObjectLogs(ctx context.Con
response := pb.GetPrecompiledObjectLogsResponse{Output: logs}
return &response, nil
}
+
+// GetPrecompiledObjectGraph returns the graph of the compiled and run example
+func (controller *playgroundController) GetPrecompiledObjectGraph(ctx
context.Context, info *pb.GetPrecompiledObjectGraphRequest)
(*pb.GetPrecompiledObjectGraphResponse, error) {
+ cd := cloud_bucket.New()
Review comment:
Why is it called _cd_, not a _cb_ for example?
##########
File path: playground/backend/internal/cloud_bucket/precompiled_objects.go
##########
@@ -128,6 +129,16 @@ func (cd *CloudStorage) GetPrecompiledObjectLogs(ctx
context.Context, precompile
return result, nil
}
+// GetPrecompiledObjectGraph returns the graph of the example
+func (cd *CloudStorage) GetPrecompiledObjectGraph(ctx context.Context,
precompiledObjectPath string) (string, error) {
+ data, err := cd.getFileFromBucket(ctx, precompiledObjectPath,
GraphExtension)
+ if err != nil {
+ return "", err
+ }
+ result := string(data)
+ return result, nil
Review comment:
```suggestion
return string(data), nil
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 715549)
Time Spent: 2.5h (was: 2h 20m)
> [Playground] Add graph to the precompiled objects
> -------------------------------------------------
>
> Key: BEAM-13725
> URL: https://issues.apache.org/jira/browse/BEAM-13725
> Project: Beam
> Issue Type: Sub-task
> Components: beam-playground
> Reporter: Aydar Zaynutdinov
> Assignee: Aydar Zaynutdinov
> Priority: P3
> Labels: beam-playground-backend, beam-playground-sprint-8
> Time Spent: 2.5h
> Remaining Estimate: 0h
>
> Add a new string field _graph_ to the precompiled objects.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
