[
https://issues.apache.org/jira/browse/BEAM-13051?focusedWorklogId=715908&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-715908
]
ASF GitHub Bot logged work on BEAM-13051:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 26/Jan/22 18:34
Start Date: 26/Jan/22 18:34
Worklog Time Spent: 10m
Work Description: TheNeuralBit commented on a change in pull request
#16541:
URL: https://github.com/apache/beam/pull/16541#discussion_r792930643
##########
File path: sdks/python/apache_beam/utils/processes_test.py
##########
@@ -48,11 +48,9 @@ def test_method_forwarding_not_windows(self, *unused_mocks):
processes.subprocess.check_call.assert_called_once_with(
['subprocess', 'check_call'], shell=False, other_arg=True)
- processes.check_output(['subprocess', 'check_output'],
- shell=False,
- other_arg=True)
Review comment:
Oh I see, sorry about that. It looks like
[`subprocess.run`](https://docs.python.org/3/library/subprocess.html#subprocess.run)
is variadic with `other_popen_kwargs`, but those are likely just passed to
[`subprocess.Popen`](https://docs.python.org/3/library/subprocess.html#subprocess.Popen).
So there is a restricted set of allowed kwargs.
Now I'm thinking what you did originally is a better resolution.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 715908)
Time Spent: 11h 20m (was: 11h 10m)
> Enable all practical pylint warnings
> ------------------------------------
>
> Key: BEAM-13051
> URL: https://issues.apache.org/jira/browse/BEAM-13051
> Project: Beam
> Issue Type: Task
> Components: sdk-py-core
> Reporter: Brian Hulette
> Assignee: Mike Hernandez
> Priority: P2
> Time Spent: 11h 20m
> Remaining Estimate: 0h
>
> We currently have 75 pylint checks disabled globally:
> https://github.com/apache/beam/blob/0863d95205410567a7ab191fd0a46308a0d54bb7/sdks/python/.pylintrc#L81
> I think some of these are impractical for Beam (e.g.
> [super-init-not-called|https://pycodequ.al/docs/pylint-messages/w0231-super-init-not-called.html]
> because of BEAM-6158), but most of them are verifying good conventions that
> we should try to stick to. Let's enable as many of the checks as possible,
> such that the only disabled checks are really impractical for Beam, or are
> incompatible with the Beam community's coding style.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
