[
https://issues.apache.org/jira/browse/BEAM-13245?focusedWorklogId=716497&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-716497
]
ASF GitHub Bot logged work on BEAM-13245:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 27/Jan/22 15:35
Start Date: 27/Jan/22 15:35
Worklog Time Spent: 10m
Work Description: mosche commented on a change in pull request #16607:
URL: https://github.com/apache/beam/pull/16607#discussion_r793731429
##########
File path:
sdks/java/io/amazon-web-services2/src/test/java/org/apache/beam/sdk/io/aws2/s3/S3ResourceIdTest.java
##########
@@ -75,6 +81,62 @@
new TestCase(
"s3://bucket/path/to/dir/", "..", RESOLVE_DIRECTORY,
"s3://bucket/path/to/"));
+ private S3ResourceId deserializeFromB64(String base64) throws Exception {
+ ByteArrayInputStream b = new
ByteArrayInputStream(Base64.getDecoder().decode(base64));
+ try (ObjectInputStream s = new ObjectInputStream(b)) {
+ return (S3ResourceId) s.readObject();
+ }
+ }
+
+ private String serializeToB64(S3ResourceId r) throws Exception {
+ ByteArrayOutputStream b = new ByteArrayOutputStream();
+ try (ObjectOutputStream s = new ObjectOutputStream(b)) {
+ s.writeObject(r);
+ }
+ return Base64.getEncoder().encodeToString(b.toByteArray());
+ }
+
+ @Test
+ public void testSerialization() throws Exception {
+ String r1Serialized =
+
"rO0ABXNyACtvcmcuYXBhY2hlLmJlYW0uc2RrLmlvLmF3czIuczMuUzNSZXNvdXJjZUlkC+xJufQ6MnwCAAVMAAZidWNrZXR0ABJMamF2YS9sYW5nL1N0cmluZztMAANrZXlxAH4AAUwADGxhc3RNb2RpZmllZHQAEExqYXZhL3V0aWwvRGF0ZTtMAAZzY2hlbWVxAH4AAUwABHNpemV0ABBMamF2YS9sYW5nL0xvbmc7eHB0AAZidWNrZXR0AAYvYS9iL2NwdAACczNw";
+ String r2Serialized =
+
"rO0ABXNyACtvcmcuYXBhY2hlLmJlYW0uc2RrLmlvLmF3czIuczMuUzNSZXNvdXJjZUlkC+xJufQ6MnwCAAVMAAZidWNrZXR0ABJMamF2YS9sYW5nL1N0cmluZztMAANrZXlxAH4AAUwADGxhc3RNb2RpZmllZHQAEExqYXZhL3V0aWwvRGF0ZTtMAAZzY2hlbWVxAH4AAUwABHNpemV0ABBMamF2YS9sYW5nL0xvbmc7eHB0AAxvdGhlci1idWNrZXR0AAYveC95L3pwdAACczNw";
+ String r3Serialized =
+
"rO0ABXNyACtvcmcuYXBhY2hlLmJlYW0uc2RrLmlvLmF3czIuczMuUzNSZXNvdXJjZUlkC+xJufQ6MnwCAAVMAAZidWNrZXR0ABJMamF2YS9sYW5nL1N0cmluZztMAANrZXlxAH4AAUwADGxhc3RNb2RpZmllZHQAEExqYXZhL3V0aWwvRGF0ZTtMAAZzY2hlbWVxAH4AAUwABHNpemV0ABBMamF2YS9sYW5nL0xvbmc7eHB0AAx0aGlyZC1idWNrZXR0AAkvZm9vL2Jhci9wdAACczNw";
+ String r4Serialized =
+
"rO0ABXNyACtvcmcuYXBhY2hlLmJlYW0uc2RrLmlvLmF3czIuczMuUzNSZXNvdXJjZUlkC+xJufQ6MnwCAAVMAAZidWNrZXR0ABJMamF2YS9sYW5nL1N0cmluZztMAANrZXlxAH4AAUwADGxhc3RNb2RpZmllZHQAEExqYXZhL3V0aWwvRGF0ZTtMAAZzY2hlbWVxAH4AAUwABHNpemV0ABBMamF2YS9sYW5nL0xvbmc7eHB0AApiYXotYnVja2V0dAAGL2EvYi9jcHQAAnMzcA==";
+
+ S3ResourceId r1 = S3ResourceId.fromComponents("s3", "bucket", "a/b/c");
+ S3ResourceId r2 = S3ResourceId.fromComponents("s3", "other-bucket",
"x/y/z").withSize(123);
+ S3ResourceId r3 =
+ S3ResourceId.fromComponents("s3", "third-bucket", "foo/bar/")
+ .withLastModified(new Date(2021, 6, 3));
Review comment:
Sorry, still issues there:
https://ci-beam.apache.org/job/beam_PreCommit_Java_Commit/20753/error-prone/new/
```
Use ZoneOffset.UTC instead of ZoneId.of("Z").
Did you mean:
Date.from(LocalDate.of(2021, 6,
3).atStartOfDay(ZoneOffset.UTC).toInstant()));
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 716497)
Time Spent: 1h (was: 50m)
> Generalize S3FileSystem to support multiple URI schemes (AWS SDK v2)
> --------------------------------------------------------------------
>
> Key: BEAM-13245
> URL: https://issues.apache.org/jira/browse/BEAM-13245
> Project: Beam
> Issue Type: Improvement
> Components: io-java-aws
> Reporter: Moritz Mack
> Assignee: Matt Rudary
> Priority: P2
> Labels: aws, aws-s3
> Time Spent: 1h
> Remaining Estimate: 0h
>
> S3FileSystem for SDK v2 should be generalized the same way as done for v1
> here: [https://github.com/apache/beam/pull/15036]
>
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
