[
https://issues.apache.org/jira/browse/BEAM-7928?focusedWorklogId=717135&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-717135
]
ASF GitHub Bot logged work on BEAM-7928:
----------------------------------------
Author: ASF GitHub Bot
Created on: 28/Jan/22 16:35
Start Date: 28/Jan/22 16:35
Worklog Time Spent: 10m
Work Description: jrmccluskey commented on a change in pull request
#16622:
URL: https://github.com/apache/beam/pull/16622#discussion_r794663757
##########
File path: sdks/go/pkg/beam/runners/dataflow/dataflow.go
##########
@@ -59,6 +59,7 @@ var (
numWorkers = flag.Int64("num_workers", 0, "Number of workers
(optional).")
maxNumWorkers = flag.Int64("max_num_workers", 0, "Maximum number
of workers during scaling (optional).")
diskSizeGb = flag.Int64("disk_size_gb", 0, "Size of root disk
for VMs, in GB (optional).")
+ diskType = flag.String("disk_type", "", "Type of root disk
for VMs (optional).")
Review comment:
Would that just be adding a `--worker_disk_type` flag that stores its
value in the `--disk_type` flag's variable? How would that interact when
considering defaults?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 717135)
Time Spent: 1.5h (was: 1h 20m)
> Being able to specify disk type and disk size
> ---------------------------------------------
>
> Key: BEAM-7928
> URL: https://issues.apache.org/jira/browse/BEAM-7928
> Project: Beam
> Issue Type: New Feature
> Components: sdk-go
> Reporter: Thomas
> Assignee: Jack McCluskey
> Priority: P3
> Labels: starter
> Time Spent: 1.5h
> Remaining Estimate: 0h
>
> Hi everyone,
> I'm willing to launch a job from a template, so I'm using
> [https://godoc.org/google.golang.org/api/dataflow/v1b3#CreateJobFromTemplateRequest]
> and then I call the `Create` method.
> With this (particularly inside `RuntimeEnvironment` type) I'm able to specify
> the machine type and so on, but I'm unable to precise disk settings (type and
> size).
>
> Do you think such settings could be there also? Or do I need to define them
> with another way?
>
> Thank you,
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
