[
https://issues.apache.org/jira/browse/BEAM-13757?focusedWorklogId=717422&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-717422
]
ASF GitHub Bot logged work on BEAM-13757:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 29/Jan/22 00:32
Start Date: 29/Jan/22 00:32
Worklog Time Spent: 10m
Work Description: lostluck commented on a change in pull request #16629:
URL: https://github.com/apache/beam/pull/16629#discussion_r794967552
##########
File path: sdks/go/pkg/beam/core/funcx/fn.go
##########
@@ -243,6 +247,16 @@ func (u *Fn) Window() (pos int, exists bool) {
return -1, false
}
+// Pane returns (index, true) iff the function expects a PaneInfo.
+func (u *Fn) Pane() (pos int, exists bool) {
Review comment:
I won't ask you to backfill tests for all the other similar methods, but
can we ad a tests for this method, for the function having a Pane and not
having a pane?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 717422)
Time Spent: 2h 20m (was: 2h 10m)
> Pane observation in user DoFN
> -----------------------------
>
> Key: BEAM-13757
> URL: https://issues.apache.org/jira/browse/BEAM-13757
> Project: Beam
> Issue Type: Bug
> Components: sdk-go
> Reporter: Ritesh Ghorse
> Assignee: Ritesh Ghorse
> Priority: P2
> Time Spent: 2h 20m
> Remaining Estimate: 0h
>
> Handle pane propagation in exec package and pane observation in user DoFns so
> that users can access additional parameter [PaneInfo
> |https://github.com/apache/beam/blob/b0e9f2638cbaca822ee6a58bd8ec0e61db8e799e/sdks/go/pkg/beam/core/typex/special.go#L77]from
> DoFn. This would help in knowing whether the pane is fired on-time, late,
> early or first and last.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
