[ 
https://issues.apache.org/jira/browse/BEAM-13734?focusedWorklogId=717434&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-717434
 ]

ASF GitHub Bot logged work on BEAM-13734:
-----------------------------------------

                Author: ASF GitHub Bot
            Created on: 29/Jan/22 00:53
            Start Date: 29/Jan/22 00:53
    Worklog Time Spent: 10m 
      Work Description: VictorPlusC commented on a change in pull request 
#16601:
URL: https://github.com/apache/beam/pull/16601#discussion_r794972956



##########
File path: 
sdks/python/apache_beam/runners/interactive/interactive_environment.py
##########
@@ -29,15 +29,22 @@
 import logging
 import os
 import tempfile
+import warnings
 from collections.abc import Iterable
+from pathlib import PurePath
 
 import apache_beam as beam
+from apache_beam.pipeline import Pipeline
+from apache_beam.runners import DataflowRunner
 from apache_beam.runners import runner
+from apache_beam.runners.direct import direct_runner
 from apache_beam.runners.interactive import cache_manager as cache
+from apache_beam.runners.interactive.interactive_runner import 
InteractiveRunner

Review comment:
       I've moved this line into the region of `get_cache_manager` where we use 
the InteractiveRunner now, thanks!




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Issue Time Tracking
-------------------

    Worklog Id:     (was: 717434)
    Time Spent: 13h 20m  (was: 13h 10m)

> Support cache directories that use GCS buckets
> ----------------------------------------------
>
>                 Key: BEAM-13734
>                 URL: https://issues.apache.org/jira/browse/BEAM-13734
>             Project: Beam
>          Issue Type: New Feature
>          Components: runner-py-interactive
>            Reporter: Victor Chen
>            Assignee: Victor Chen
>            Priority: P2
>          Time Spent: 13h 20m
>  Remaining Estimate: 0h
>
> * Builds off of the work accomplished under BEAM-13685
>  * Modified interactive_environment.py to support caching to a bucket on GCS 
> for batch processing pipelines
>  * If a specified bucket does not exist, the pipeline will terminate and 
> return an error specifying that the bucket does not exist
>  * Added cleanup() functionality to cache_manager.py, to enable the 
> FileBasedCacheManager class to automatically delete cached values on GCS when 
> a bucket path is specified
>  * Added docstring to interactive_beam.py with an example of GCS path 
> assignment
>  * Cached files on GCS will be stored under a directory represented by the 
> value of id(pipeline).
>  ** Example cached path: gs://my-gcs-bucket/cache/dir/id(pipeline)



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

Reply via email to