[
https://issues.apache.org/jira/browse/BEAM-13760?focusedWorklogId=717542&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-717542
]
ASF GitHub Bot logged work on BEAM-13760:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 29/Jan/22 13:51
Start Date: 29/Jan/22 13:51
Worklog Time Spent: 10m
Work Description: codecov[bot] edited a comment on pull request #16641:
URL: https://github.com/apache/beam/pull/16641#issuecomment-1024459011
#
[Codecov](https://codecov.io/gh/apache/beam/pull/16641?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
Report
> Merging
[#16641](https://codecov.io/gh/apache/beam/pull/16641?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
(1855f46) into
[master](https://codecov.io/gh/apache/beam/commit/1351030158c25c0742d6c0b9aa46c27cbecd333c?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
(1351030) will **increase** coverage by `37.18%`.
> The diff coverage is `100.00%`.
> :exclamation: Current head 1855f46 differs from pull request most recent
head 0d4fae6. Consider uploading reports for the commit 0d4fae6 to get more
accurate results
[](https://codecov.io/gh/apache/beam/pull/16641?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #16641 +/- ##
===========================================
+ Coverage 46.43% 83.62% +37.18%
===========================================
Files 201 452 +251
Lines 19787 62097 +42310
===========================================
+ Hits 9189 51929 +42740
- Misses 9612 10168 +556
+ Partials 986 0 -986
```
| [Impacted
Files](https://codecov.io/gh/apache/beam/pull/16641?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
| Coverage Δ | |
|---|---|---|
|
[...apache\_beam/runners/dataflow/internal/apiclient.py](https://codecov.io/gh/apache/beam/pull/16641/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9kYXRhZmxvdy9pbnRlcm5hbC9hcGljbGllbnQucHk=)
| `77.39% <100.00%> (ø)` | |
|
[sdks/go/pkg/beam/core/util/reflectx/types.go](https://codecov.io/gh/apache/beam/pull/16641/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9nby9wa2cvYmVhbS9jb3JlL3V0aWwvcmVmbGVjdHgvdHlwZXMuZ28=)
| | |
|
[sdks/go/pkg/beam/core/graph/coder/row\_encoder.go](https://codecov.io/gh/apache/beam/pull/16641/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9nby9wa2cvYmVhbS9jb3JlL2dyYXBoL2NvZGVyL3Jvd19lbmNvZGVyLmdv)
| | |
|
[sdks/go/pkg/beam/core/runtime/graphx/translate.go](https://codecov.io/gh/apache/beam/pull/16641/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9nby9wa2cvYmVhbS9jb3JlL3J1bnRpbWUvZ3JhcGh4L3RyYW5zbGF0ZS5nbw==)
| | |
|
[sdks/go/pkg/beam/io/filesystem/local/local.go](https://codecov.io/gh/apache/beam/pull/16641/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9nby9wa2cvYmVhbS9pby9maWxlc3lzdGVtL2xvY2FsL2xvY2FsLmdv)
| | |
|
[sdks/go/pkg/beam/core/runtime/graphx/tree.go](https://codecov.io/gh/apache/beam/pull/16641/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9nby9wa2cvYmVhbS9jb3JlL3J1bnRpbWUvZ3JhcGh4L3RyZWUuZ28=)
| | |
|
[sdks/go/pkg/beam/io/textio/sdf.go](https://codecov.io/gh/apache/beam/pull/16641/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9nby9wa2cvYmVhbS9pby90ZXh0aW8vc2RmLmdv)
| | |
|
[sdks/go/pkg/beam/combine.go](https://codecov.io/gh/apache/beam/pull/16641/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9nby9wa2cvYmVhbS9jb21iaW5lLmdv)
| | |
|
[sdks/go/pkg/beam/core/util/hooks/hooks.go](https://codecov.io/gh/apache/beam/pull/16641/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9nby9wa2cvYmVhbS9jb3JlL3V0aWwvaG9va3MvaG9va3MuZ28=)
| | |
|
[sdks/go/pkg/beam/core/runtime/genx/genx.go](https://codecov.io/gh/apache/beam/pull/16641/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9nby9wa2cvYmVhbS9jb3JlL3J1bnRpbWUvZ2VueC9nZW54Lmdv)
| | |
| ... and [644
more](https://codecov.io/gh/apache/beam/pull/16641/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
| |
------
[Continue to review full report at
Codecov](https://codecov.io/gh/apache/beam/pull/16641?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn
more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by
[Codecov](https://codecov.io/gh/apache/beam/pull/16641?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
Last update
[1351030...0d4fae6](https://codecov.io/gh/apache/beam/pull/16641?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
Read the [comment
docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 717542)
Remaining Estimate: 46h 50m (was: 47h)
Time Spent: 1h 10m (was: 1h)
> Add randomness to default Dataflow job name in Python sdk
> ---------------------------------------------------------
>
> Key: BEAM-13760
> URL: https://issues.apache.org/jira/browse/BEAM-13760
> Project: Beam
> Issue Type: Improvement
> Components: runner-dataflow
> Reporter: Will Nicholson
> Assignee: Will Nicholson
> Priority: P2
> Original Estimate: 48h
> Time Spent: 1h 10m
> Remaining Estimate: 46h 50m
>
> Currently, when a Dataflow job is created with the default name in python,
> the name is a concatenation of the word "beamapp", the username, and the time
> in microseconds, as seen
> [here|https://github.com/apache/beam/blob/master/sdks/python/apache_beam/runners/dataflow/internal/apiclient.py#L415-L428].
> Therefore, when two jobs are created by the same user at the same time, the
> jobs names collide and the second job fails.
> However, the Java SDK has already solved this problem, by appending a random
> hex string to the job name, seen
> [here|https://github.com/apache/beam/blob/master/sdks/java/core/src/main/java/org/apache/beam/sdk/options/PipelineOptions.java#L338-L351].
> The objective of this issue is to align the python sdk with the java sdk, by
> appending a random string to the default job name.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
