[
https://issues.apache.org/jira/browse/BEAM-4032?focusedWorklogId=717623&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-717623
]
ASF GitHub Bot logged work on BEAM-4032:
----------------------------------------
Author: ASF GitHub Bot
Created on: 30/Jan/22 00:16
Start Date: 30/Jan/22 00:16
Worklog Time Spent: 10m
Work Description: AnandInguva commented on a change in pull request
#16633:
URL: https://github.com/apache/beam/pull/16633#discussion_r795107118
##########
File path: sdks/python/apache_beam/runners/portability/stager_test.py
##########
@@ -723,6 +765,65 @@ def test_remove_dependency_from_requirements(self):
self.assertEqual(['apache_beam\n', 'avro-python3\n', 'numpy\n'],
sorted(lines))
+ def _create_file(
+ self, requirements_file, temp_dir, populate_cache_with_sdists):
+ if not populate_cache_with_sdists:
+ self.create_temp_file(os.path.join(temp_dir, 'nothing.whl'), 'Fake whl')
+ self.create_temp_file(
+ os.path.join(temp_dir, 'nothing.tar.gz'), 'Fake tarball')
+ else:
+ self.create_temp_file(
+ os.path.join(temp_dir, 'nothing.tar.gz'), 'Fake tarball')
Review comment:
If we download whls and if a whl is not present on PyPI, we download
sdist. That is the reason why it is present in both branches.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 717623)
Time Spent: 13h 50m (was: 13h 40m)
> Support staging binary distributions of dependency packages.
> ------------------------------------------------------------
>
> Key: BEAM-4032
> URL: https://issues.apache.org/jira/browse/BEAM-4032
> Project: Beam
> Issue Type: Improvement
> Components: sdk-py-core
> Reporter: Valentyn Tymofieiev
> Assignee: Anand Inguva
> Priority: P2
> Time Spent: 13h 50m
> Remaining Estimate: 0h
>
> requirements.txt only supports source-distribution dependencies [1].
> --extra_packages does not officially support wheel files [2].
> It is possible to expand this to support binary distributions as long as we
> have the knowledge of the target platform.
> We should take into consideration the mechanisms of staging dependencies
> through portability framework, and perhaps consolidate some of the existing
> options.
> [https://github.com/apache/beam/blob/a79d1b4fc27eb81db0d9a773047820a206f3d238/sdks/python/apache_beam/runners/dataflow/internal/dependency.py#L260]
> [https://github.com/apache/beam/blob/a79d1b4fc27eb81db0d9a773047820a206f3d238/sdks/python/apache_beam/runners/dataflow/internal/dependency.py#L188]
>
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
