[
https://issues.apache.org/jira/browse/BEAM-10838?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17485505#comment-17485505
]
Conor Landry commented on BEAM-10838:
-------------------------------------
I have a draft PR up for this that I'd like to get some feedback on. I've added
comments to the PR with more specifics. Overall, the changes I've made are
relatively minor and should preserve the existing functionality while allowing
pipeline developers to have more control over ssl setup. Future improvements
should be a bit easier too as SSL configuration isn't intertwined with the rest
of the ConnectionConfiguration class.
I'm a bit confused with how to properly test this though. I don't see any unit
testing surrounding ConnectionConfiguration to reference and it looks like all
the tests are centered around integration testing against ES clusters. Should I
add some unit tests for the ConnectionConfiguration class to verify methods
like `createClient()` construct properly?
PR here https://github.com/apache/beam/pull/16690
> Add a withSSLContext builder method to ElasticsearchIO
> -------------------------------------------------------
>
> Key: BEAM-10838
> URL: https://issues.apache.org/jira/browse/BEAM-10838
> Project: Beam
> Issue Type: New Feature
> Components: io-java-elasticsearch
> Reporter: Conor Landry
> Assignee: Conor Landry
> Priority: P2
> Time Spent: 10m
> Remaining Estimate: 0h
>
> Currently, the ElasticsearchIO transforms have only one way to securely
> read/write Elasticsearch by using the withKeystorePath builder method and
> providing the location of a keystore containing a client key in jks format.
> This is a bit limiting, especially for Elasticsearch users not depending on
> shield to secure their clusters. I'd like to propose the addition of the
> builder method withSSLContext(SSLContext sslContext, which delegates to
> `httpClientBuilder.setSSLContext`.
> If this is (y), I can start working on it.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
