[
https://issues.apache.org/jira/browse/BEAM-10838?focusedWorklogId=719036&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-719036
]
ASF GitHub Bot logged work on BEAM-10838:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 01/Feb/22 21:56
Start Date: 01/Feb/22 21:56
Worklog Time Spent: 10m
Work Description: clandry94 commented on a change in pull request #16690:
URL: https://github.com/apache/beam/pull/16690#discussion_r797066238
##########
File path:
sdks/java/io/elasticsearch/src/main/java/org/apache/beam/sdk/io/elasticsearch/ElasticsearchIO.java
##########
@@ -309,6 +309,71 @@ static JsonNode parseResponse(HttpEntity responseEntity)
throws IOException {
return responses;
}
+ @AutoValue
+ public abstract static class SslConfiguration implements Serializable {
+ public abstract @Nullable String getKeystoreType();
+
+ public abstract @Nullable String getKeystorePath();
+
+ public abstract @Nullable String getKeystorePassword();
+
+ public abstract @Nullable TrustStrategy getTrustStrategy();
+
+ abstract Builder builder();
+
+ @AutoValue.Builder
+ abstract static class Builder {
+ abstract Builder setKeystoreType(String type);
Review comment:
Aside from reorganizing classes, the biggest win of this PR is exposing
the ability for pipeline developers to use their keystore of choice- jks,
pkcs12, etc
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 719036)
Time Spent: 40m (was: 0.5h)
> Add a withSSLContext builder method to ElasticsearchIO
> -------------------------------------------------------
>
> Key: BEAM-10838
> URL: https://issues.apache.org/jira/browse/BEAM-10838
> Project: Beam
> Issue Type: New Feature
> Components: io-java-elasticsearch
> Reporter: Conor Landry
> Assignee: Conor Landry
> Priority: P2
> Time Spent: 40m
> Remaining Estimate: 0h
>
> Currently, the ElasticsearchIO transforms have only one way to securely
> read/write Elasticsearch by using the withKeystorePath builder method and
> providing the location of a keystore containing a client key in jks format.
> This is a bit limiting, especially for Elasticsearch users not depending on
> shield to secure their clusters. I'd like to propose the addition of the
> builder method withSSLContext(SSLContext sslContext, which delegates to
> `httpClientBuilder.setSSLContext`.
> If this is (y), I can start working on it.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
