[
https://issues.apache.org/jira/browse/BEAM-13786?focusedWorklogId=719429&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-719429
]
ASF GitHub Bot logged work on BEAM-13786:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 02/Feb/22 14:57
Start Date: 02/Feb/22 14:57
Worklog Time Spent: 10m
Work Description: ilya-kozyrev commented on a change in pull request
#16701:
URL: https://github.com/apache/beam/pull/16701#discussion_r797692523
##########
File path: playground/infrastructure/cd_helper.py
##########
@@ -41,14 +41,18 @@ class CDHelper:
It is used to save beam examples/katas/tests and their output on the GCS.
"""
-
def store_examples(self, examples: List[Example]):
"""
Store beam examples and their output in the Google Cloud.
+
+ Outputs for multifile examples are left empty.
"""
- logging.info("Start of executing Playground examples ...")
- asyncio.run(self._get_outputs(examples))
- logging.info("Finish of executing Playground examples")
+ single_file_examples = [
+ example for example in examples if example.tag.multifile is False
+ ]
Review comment:
what about use filter function ro filtering?
```suggestion
single_file_examples = filter(lambda example: example.multifile,
examples)
```
Just remember, that filter returns a filter object, that can be iterated,
but is not available for slices
##########
File path: playground/infrastructure/ci_helper.py
##########
@@ -42,10 +42,12 @@ async def verify_examples(self, examples: List[Example]):
1. Find all beam examples starting from directory
os.getenv("BEAM_ROOT_DIR")
2. Group code of examples by their SDK.
- 3. Run processing for all examples to verify examples' code.
+ 3. Run processing for single-file examples to verify examples' code.
"""
- await get_statuses(examples)
- await self._verify_examples(examples)
+ single_file_examples = [example for example in examples
+ if example.tag.multifile is False]
Review comment:
same, can we use the filter for filtering? :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 719429)
Time Spent: 50m (was: 40m)
> [Playground] Update CI/CD to verify only single-file examples
> -------------------------------------------------------------
>
> Key: BEAM-13786
> URL: https://issues.apache.org/jira/browse/BEAM-13786
> Project: Beam
> Issue Type: Bug
> Components: beam-playground
> Reporter: Aydar Zaynutdinov
> Assignee: Pavel Avilov
> Priority: P3
> Labels: beam-playground-backend, beam-playground-sprint-8
> Time Spent: 50m
> Remaining Estimate: 0h
>
> Now CI/CD verifies all found examples by sending them to the backend. Need
> update CI/CD to verify only examples with _multifile = false_
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
