[
https://issues.apache.org/jira/browse/BEAM-13399?focusedWorklogId=719689&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-719689
]
ASF GitHub Bot logged work on BEAM-13399:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 02/Feb/22 21:00
Start Date: 02/Feb/22 21:00
Worklog Time Spent: 10m
Work Description: jrmccluskey commented on a change in pull request
#16671:
URL: https://github.com/apache/beam/pull/16671#discussion_r798008460
##########
File path: sdks/go/pkg/beam/core/runtime/xlangx/registry.go
##########
@@ -220,7 +220,11 @@ func (r *registry) getHandlerFunc(urn, expansionAddr
string) (HandlerFunc, strin
// By the time this is called, we want *some* kind of HandlerFunc at
all,
// So first we check for the hard override.
ns, config := parseAddr(expansionAddr)
- if ns == hardOverrideNamespace {
+ if ns == autoNamespace {
+ // Leave expansionAddr unmodified so the autoNamespace keyword
sticks.
+ // We strip it manually in the HandlerFunc.
+ return QueryAutomatedExpansionService, expansionAddr
Review comment:
I see what you're getting at. First instinct is to move the
`autoJavaNamespace` check last so we allow the urn overrides to work and enable
that behavior.
Just throwing the auto keyword and corresponding handler into the map would
just sort of work, but only if there was an appropriate place to register it
easily. So far I haven't seen a sensible place to do this, as I doubt we want
every new registry to have this
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@beam.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 719689)
Time Spent: 22h 10m (was: 22h)
> [Go SDK] Add automated expansion service start up feature
> ---------------------------------------------------------
>
> Key: BEAM-13399
> URL: https://issues.apache.org/jira/browse/BEAM-13399
> Project: Beam
> Issue Type: Improvement
> Components: cross-language, sdk-go
> Reporter: Jack McCluskey
> Assignee: Jack McCluskey
> Priority: P2
> Time Spent: 22h 10m
> Remaining Estimate: 0h
>
> Add Go SDK support for automated expansion service start-up if one is not
> provided, following the example of the Python implementation.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
