[ 
https://issues.apache.org/jira/browse/BEAM-13814?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17486628#comment-17486628
 ] 

Kiley Sok commented on BEAM-13814:
----------------------------------

This should tell us what version we're using, so we can disable it for < 11 
[https://github.com/apache/beam/blob/master/buildSrc/src/main/groovy/org/apache/beam/gradle/BeamModulePlugin.groovy#L2223-L2228]

 

Looks like we don't have a general Java 11 precommit, would 
beam_PreCommit_Java_Examples_Dataflow_Java11_Commit catch everything?

> Run errorprone with Java 11 (required in 2.11.0 and newer)
> ----------------------------------------------------------
>
>                 Key: BEAM-13814
>                 URL: https://issues.apache.org/jira/browse/BEAM-13814
>             Project: Beam
>          Issue Type: Improvement
>          Components: build-system
>            Reporter: Brian Hulette
>            Priority: P2
>
> errorprone 2.11.0 only supports JDK 11 (but can still validate Java 8 
> classes). We should find a way to upgrade errorprone while still supporting 
> Java 8. 
> Perhaps we could modify BeamModulePlugin to disable errorprone when building 
> with Java 8, and make sure that there's a Java 11 PreCommit that will run it?



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

Reply via email to