[
https://issues.apache.org/jira/browse/BEAM-13024?focusedWorklogId=720468&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-720468
]
ASF GitHub Bot logged work on BEAM-13024:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 03/Feb/22 22:25
Start Date: 03/Feb/22 22:25
Worklog Time Spent: 10m
Work Description: lostluck edited a comment on pull request #16719:
URL: https://github.com/apache/beam/pull/16719#issuecomment-1029453153
> > Would it be possible to turn the manual test you have into an
Integration test?
>
> Done - good call! Do those run automatically or do we need to trigger them
with a comment command?
If you add them to the primitives package, they should run automatically
against the Python Portable Runner. But then also against the other runners in
post commit. If you expect any particular runner to fail, you can add the test
name to the appropriate filter list in the integration package:
https://github.com/apache/beam/blob/master/sdks/go/test/integration/integration.go#L63
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 720468)
Time Spent: 2h 20m (was: 2h 10m)
> [Go SDK] Export flags to PipelineOptions on non-dataflow runners.
> -----------------------------------------------------------------
>
> Key: BEAM-13024
> URL: https://issues.apache.org/jira/browse/BEAM-13024
> Project: Beam
> Issue Type: Bug
> Components: sdk-go
> Reporter: Robert Burke
> Assignee: Danny McCormick
> Priority: P2
> Time Spent: 2h 20m
> Remaining Estimate: 0h
>
> Recently the Go SDK dataflow runner code began adding explicitly set flags to
> the pipeline options. This made them available to worker code at execution
> time, if queried with `beam.PipelineOptions.Get`.
> The proposal is to generalize this code and make use of it in all runners
> (including the direct runner). This would make PipelineOptions a useful
> concept in the Go SDK.
> Flag filtering and adding here:
>
> [https://github.com/apache/beam/blob/master/sdks/go/pkg/beam/runners/dataflow/dataflow.go#L281]
> Once implemented for all runners, it should be possible to test use of this
> in the integration tests to ensure continued function.
> Danny wrote a quick Doc:
> https://docs.google.com/document/d/1AyO5SDEd_DzyOyrz_TkyDLUv19eLsKI97vKM8I7fQ9o/edit#
>
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
