[
https://issues.apache.org/jira/browse/BEAM-6981?focusedWorklogId=222217&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-222217
]
ASF GitHub Bot logged work on BEAM-6981:
----------------------------------------
Author: ASF GitHub Bot
Created on: 03/Apr/19 09:01
Start Date: 03/Apr/19 09:01
Worklog Time Spent: 10m
Work Description: adude3141 commented on pull request #8207: [BEAM-6981]
use beam module global configuration for javadoc creation
URL: https://github.com/apache/beam/pull/8207
Currently we do not set file encoding for javadoc creation and therefore
rely on system default encoding.
This might lead to unexpected results.
------------------------
Thank you for your contribution! Follow this checklist to help us
incorporate your contribution quickly and easily:
- [ ] [**Choose
reviewer(s)**](https://beam.apache.org/contribute/#make-your-change) and
mention them in a comment (`R: @username`).
- [ ] Format the pull request title like `[BEAM-XXX] Fixes bug in
ApproximateQuantiles`, where you replace `BEAM-XXX` with the appropriate JIRA
issue, if applicable. This will automatically link the pull request to the
issue.
- [ ] If this contribution is large, please file an Apache [Individual
Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
Post-Commit Tests Status (on master branch)
------------------------------------------------------------------------------------------------
Lang | SDK | Apex | Dataflow | Flink | Gearpump | Samza | Spark
--- | --- | --- | --- | --- | --- | --- | ---
Go | [](https://builds.apache.org/job/beam_PostCommit_Go/lastCompletedBuild/)
| --- | --- | --- | --- | --- | ---
Java | [](https://builds.apache.org/job/beam_PostCommit_Java/lastCompletedBuild/)
| [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Apex/lastCompletedBuild/)
| [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Dataflow/lastCompletedBuild/)
| [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Flink/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Java_PVR_Flink_Batch/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Java_PVR_Flink_Streaming/lastCompletedBuild/)
| [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Gearpump/lastCompletedBuild/)
| [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Samza/lastCompletedBuild/)
| [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Spark/lastCompletedBuild/)
Python | [](https://builds.apache.org/job/beam_PostCommit_Python_Verify/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Python3_Verify/lastCompletedBuild/)
| --- | [](https://builds.apache.org/job/beam_PostCommit_Py_VR_Dataflow/lastCompletedBuild/)
<br> [](https://builds.apache.org/job/beam_PostCommit_Py_ValCont/lastCompletedBuild/)
| [](https://builds.apache.org/job/beam_PreCommit_Python_PVR_Flink_Cron/lastCompletedBuild/)
| --- | --- | ---
Pre-Commit Tests Status (on master branch)
------------------------------------------------------------------------------------------------
--- |Java | Python | Go | Website
--- | --- | --- | --- | ---
Non-portable | [](https://builds.apache.org/job/beam_PreCommit_Java_Cron/lastCompletedBuild/)
| [](https://builds.apache.org/job/beam_PreCommit_Python_Cron/lastCompletedBuild/)
| [](https://builds.apache.org/job/beam_PreCommit_Go_Cron/lastCompletedBuild/)
| [](https://builds.apache.org/job/beam_PreCommit_Website_Cron/lastCompletedBuild/)
Portable | --- | [](https://builds.apache.org/job/beam_PreCommit_Portable_Python_Cron/lastCompletedBuild/)
| --- | ---
See
[.test-infra/jenkins/README](https://github.com/apache/beam/blob/master/.test-infra/jenkins/README.md)
for trigger phrase, status and link of all Jenkins jobs.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 222217)
Time Spent: 10m
Remaining Estimate: 0h
> :beam-sdks-java-javadoc:aggregateJavadoc has no encoding set
> ------------------------------------------------------------
>
> Key: BEAM-6981
> URL: https://issues.apache.org/jira/browse/BEAM-6981
> Project: Beam
> Issue Type: Bug
> Components: build-system
> Reporter: Michael Luckey
> Assignee: Michael Luckey
> Priority: Major
> Time Spent: 10m
> Remaining Estimate: 0h
>
> Beams javadoc project does not apply beam module plugin.
> As rhe aggregateJavadoc tasks configuration does not set
> {noformat}
> options.encoding = 'UTF-8'
> {noformat}
> and the option is also not inherited from beam modules applyJavaNature
> current javadoc creation relies on systems default file encoding (or whatever
> happens to be active for the jvm)
> So we either need to set it explicitly, or apply our plugin. The latter is
> probably better, as it ensures all configuration globally set for java
> projects will be used.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
