[
https://issues.apache.org/jira/browse/BEAM-6936?focusedWorklogId=222226&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-222226
]
ASF GitHub Bot logged work on BEAM-6936:
----------------------------------------
Author: ASF GitHub Bot
Created on: 03/Apr/19 09:21
Start Date: 03/Apr/19 09:21
Worklog Time Spent: 10m
Work Description: mwalenia commented on pull request #8183: [BEAM-6936]
Added Jenkins jobs running Java examples on Dataflow with Java 11
URL: https://github.com/apache/beam/pull/8183#discussion_r271651316
##########
File path: runners/google-cloud-dataflow-java/examples/build.gradle
##########
@@ -87,6 +87,61 @@ task preCommitFnApiWorker(type: Test) {
}
}
+task postCommitFnApiWorkerJava11(type: Test) {
+ dependsOn ":beam-runners-google-cloud-dataflow-java-fn-api-worker:shadowJar"
+ dependsOn
":beam-runners-google-cloud-dataflow-java:buildAndPushDockerContainer"
+
+ def dataflowWorkerJar = project.findProperty('dataflowWorkerJar') ?:
project(":beam-runners-google-cloud-dataflow-java-fn-api-worker").shadowJar.archivePath
+ def preCommitBeamTestPipelineOptions = [
+ "--project=${gcpProject}",
+ "--tempRoot=${gcsTempRoot}",
+ "--runner=TestDataflowRunner",
+ "--dataflowWorkerJar=${dataflowWorkerJar}",
+ "--workerHarnessContainerImage=${dockerImageName}",
+ "--experiments=${fnapiExperiments}",
+ ]
+ testClassesDirs =
files(project(":beam-examples-java").sourceSets.test.output.classesDirs)
+ include "**/WordCountIT.class"
+ include "**/WindowedWordCountIT.class"
+ forkEvery 1
+ maxParallelForks 4
+ systemProperty "beamTestPipelineOptions",
JsonOutput.toJson(preCommitBeamTestPipelineOptions)
+ useJUnit {
+ excludeCategories 'org.apache.beam.sdk.testing.StreamingIT'
+ }
+}
+
+task postCommitLegacyWorkerJava11(type: Test) {
Review comment:
Unfortunately it wasn't possible. I couldn't find a way of extracting common
configuration to another element. Setting system properties requires `Test`
task type and those properties are restricted in scope to a single task - I
experimented with setting a property in a task with `dependsOn` directive, but
it wasn't effective. Do you know of another way of extracting this?
@adude3141 it's also a reply to your general remark, the solution you linked
didn't work. I believe that currently the best way is to duplicate those tasks.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 222226)
Time Spent: 1h 40m (was: 1.5h)
> Add a Jenkins job running Java examples on Java 11 Dataflow
> -----------------------------------------------------------
>
> Key: BEAM-6936
> URL: https://issues.apache.org/jira/browse/BEAM-6936
> Project: Beam
> Issue Type: Sub-task
> Components: examples-java, testing
> Reporter: Michal Walenia
> Assignee: Michal Walenia
> Priority: Minor
> Time Spent: 1h 40m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
