[
https://issues.apache.org/jira/browse/BEAM-11997?focusedWorklogId=721276&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-721276
]
ASF GitHub Bot logged work on BEAM-11997:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 05/Feb/22 00:04
Start Date: 05/Feb/22 00:04
Worklog Time Spent: 10m
Work Description: pabloem commented on a change in pull request #15549:
URL: https://github.com/apache/beam/pull/15549#discussion_r799890311
##########
File path:
sdks/java/io/redis/src/main/java/org/apache/beam/sdk/io/redis/RedisIO.java
##########
@@ -447,7 +388,7 @@ public void processElement(ProcessContext c) {
}
})
.withSideInputs(empty));
- return materialized.apply(Reshuffle.viaRandomKey());
+ return materialized.apply(Distinct.create());
Review comment:
I am not ready to mark this as resolved yet - this approach using
`Distinct` may be a problem in streaming, so I want to make sure I read the
guarantees properly
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 721276)
Time Spent: 11h 40m (was: 11.5h)
> Implement RedisIO on top of Splittable DoFn
> -------------------------------------------
>
> Key: BEAM-11997
> URL: https://issues.apache.org/jira/browse/BEAM-11997
> Project: Beam
> Issue Type: Improvement
> Components: io-java-redis
> Reporter: Boyuan Zhang
> Assignee: Miguel Anzo
> Priority: P2
> Time Spent: 11h 40m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
