[
https://issues.apache.org/jira/browse/BEAM-13838?focusedWorklogId=721826&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-721826
]
ASF GitHub Bot logged work on BEAM-13838:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 07/Feb/22 10:25
Start Date: 07/Feb/22 10:25
Worklog Time Spent: 10m
Work Description: KhaninArtur commented on a change in pull request
#16754:
URL: https://github.com/apache/beam/pull/16754#discussion_r800511125
##########
File path: playground/infrastructure/helper.py
##########
@@ -341,13 +342,13 @@ def _validate(tag: dict, supported_categories: List[str])
-> bool:
# check that context line's value is integer
context_line = tag.get(TagFields.context_line)
if not isinstance(context_line, int):
- logging.error(
- "tag's field context_line is incorrect: %s \n"
- "context_line variable should be integer format, "
- "but tag contains: %s",
- tag,
- context_line)
- valid = False
+ logging.error(
+ "tag's field context_line is incorrect: %s \n"
+ "context_line variable should be integer format, "
Review comment:
I suppose, since `context_line` is a variable, it is better to start it
with a lowercase letter, what do you think?
##########
File path: playground/infrastructure/grpc_client.py
##########
@@ -144,9 +145,12 @@ async def get_graph(self, pipeline_uuid: str) -> str:
request = api_pb2.GetGraphRequest(pipeline_uuid=pipeline_uuid)
try:
response = await self._stub.GetGraph(request)
+ if response.graph == "":
+ logging.warning("Graph for %s wasn't generated", example_filepath)
return response.graph
except grpc.RpcError:
# Some examples doesn't have graph (katas)
Review comment:
```suggestion
# Some examples don't have a graph (e.g. katas)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 721826)
Time Spent: 40m (was: 0.5h)
> [Playground] Add logs in case of empty graph for CD step
> --------------------------------------------------------
>
> Key: BEAM-13838
> URL: https://issues.apache.org/jira/browse/BEAM-13838
> Project: Beam
> Issue Type: Improvement
> Components: beam-playground
> Reporter: Aydar Zaynutdinov
> Assignee: Aydar Zaynutdinov
> Priority: P3
> Labels: beam-playground-backend, beam-playground-sprint-8
> Time Spent: 40m
> Remaining Estimate: 0h
>
> Need to add an informative log into CD step in case of receiving empty graph.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
