[ https://issues.apache.org/jira/browse/BEAM-13419 ]
Danny McCormick deleted comment on BEAM-13419:
----------------------------------------
was (Author: JIRAUSER282469):
I hit send just too soon on that - as best I can tell, it looks like on the
dataflow runner specifically beam.Run doesn't actually start the pipeline if
beam.Initialized() is false. I think that is the underlying issue here and we
should just handle it on the dataflow runner.
Sorry for the false alarm [~danoliveira]
> Add Go integration test errors when forgetting ptest.Main/beam.Init
> -------------------------------------------------------------------
>
> Key: BEAM-13419
> URL: https://issues.apache.org/jira/browse/BEAM-13419
> Project: Beam
> Issue Type: Improvement
> Components: sdk-go
> Reporter: Daniel Oliveira
> Assignee: Danny McCormick
> Priority: P2
>
> Currently when someone writes an integration test and forgets to put
> ptest.Main into TestMain (or their own code calling beam.Init), then the SDK
> harness runs the tests as unit tests and ends up passing them because
> ptest.Run and beam.Run seem to just instantly pass without a problem when
> beam.Init hasn't been called.
> The end result is that SDK harnesses in this setup just instantly pass all
> the tests and then close without any error messages.
> This code path should have an error added so that if beam.Init hasn't been
> run when ptest.Run executes, then it fails with an error.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
