[
https://issues.apache.org/jira/browse/BEAM-13419?focusedWorklogId=722240&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-722240
]
ASF GitHub Bot logged work on BEAM-13419:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 07/Feb/22 19:48
Start Date: 07/Feb/22 19:48
Worklog Time Spent: 10m
Work Description: codecov[bot] edited a comment on pull request #16765:
URL: https://github.com/apache/beam/pull/16765#issuecomment-1031836933
#
[Codecov](https://codecov.io/gh/apache/beam/pull/16765?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
Report
> Merging
[#16765](https://codecov.io/gh/apache/beam/pull/16765?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
(132a32a) into
[master](https://codecov.io/gh/apache/beam/commit/64581e0b5a1ff9c1bb39f3b9269714016f97963f?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
(64581e0) will **decrease** coverage by `0.00%`.
> The diff coverage is `0.00%`.
[](https://codecov.io/gh/apache/beam/pull/16765?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #16765 +/- ##
==========================================
- Coverage 46.49% 46.49% -0.01%
==========================================
Files 202 202
Lines 19938 19940 +2
==========================================
Hits 9271 9271
- Misses 9677 9679 +2
Partials 990 990
```
| [Impacted
Files](https://codecov.io/gh/apache/beam/pull/16765?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
| Coverage Δ | |
|---|---|---|
|
[sdks/go/pkg/beam/runners/dataflow/dataflow.go](https://codecov.io/gh/apache/beam/pull/16765/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9nby9wa2cvYmVhbS9ydW5uZXJzL2RhdGFmbG93L2RhdGFmbG93Lmdv)
| `5.21% <0.00%> (-0.10%)` | :arrow_down: |
------
[Continue to review full report at
Codecov](https://codecov.io/gh/apache/beam/pull/16765?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn
more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by
[Codecov](https://codecov.io/gh/apache/beam/pull/16765?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
Last update
[64581e0...132a32a](https://codecov.io/gh/apache/beam/pull/16765?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
Read the [comment
docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 722240)
Time Spent: 40m (was: 0.5h)
> Add Go integration test errors when forgetting ptest.Main/beam.Init
> -------------------------------------------------------------------
>
> Key: BEAM-13419
> URL: https://issues.apache.org/jira/browse/BEAM-13419
> Project: Beam
> Issue Type: Improvement
> Components: sdk-go
> Reporter: Daniel Oliveira
> Assignee: Danny McCormick
> Priority: P2
> Time Spent: 40m
> Remaining Estimate: 0h
>
> Currently when someone writes an integration test and forgets to put
> ptest.Main into TestMain (or their own code calling beam.Init), then the SDK
> harness runs the tests as unit tests and ends up passing them because
> ptest.Run and beam.Run seem to just instantly pass without a problem when
> beam.Init hasn't been called.
> The end result is that SDK harnesses in this setup just instantly pass all
> the tests and then close without any error messages.
> This code path should have an error added so that if beam.Init hasn't been
> run when ptest.Run executes, then it fails with an error.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
