[
https://issues.apache.org/jira/browse/BEAM-13193?focusedWorklogId=722600&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-722600
]
ASF GitHub Bot logged work on BEAM-13193:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 08/Feb/22 06:16
Start Date: 08/Feb/22 06:16
Worklog Time Spent: 10m
Work Description: lukecwik commented on a change in pull request #16769:
URL: https://github.com/apache/beam/pull/16769#discussion_r801296671
##########
File path:
sdks/java/fn-execution/src/main/java/org/apache/beam/sdk/fn/data/BeamFnDataOutboundAggregator.java
##########
@@ -199,7 +210,14 @@ public void sendBufferedDataAndFinishOutboundStreams() {
.setIsLast(true);
entry.getValue().resetStats();
}
+ if (collectElementsIfNoFlushes && !hasFlushedForBundle) {
+ return bufferedElements.build();
+ }
outboundObserver.onNext(bufferedElements.build());
+ // This is now at the end of a bundle, so we reset hasFlushedForBundle to
prepare for new
+ // bundles.
+ hasFlushedForBundle = false;
Review comment:
I'm not following since
sendOrCollectBufferedDataAndFinishOutboundStreams() is invoked by the bundle
processing thread and flush is invoked by the periodic flush thread.,x
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 722600)
Time Spent: 19h 10m (was: 19h)
> Optional data embedding in Fn API control request and response
> --------------------------------------------------------------
>
> Key: BEAM-13193
> URL: https://issues.apache.org/jira/browse/BEAM-13193
> Project: Beam
> Issue Type: New Feature
> Components: sdk-java-harness, sdk-py-harness
> Reporter: Yichi Zhang
> Priority: P2
> Time Spent: 19h 10m
> Remaining Estimate: 0h
>
> https://docs.google.com/document/d/14p8Y_n4IY5n9L_I9l5x9lVGgml4ZzdCw645HldndCrw/edit
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
