[
https://issues.apache.org/jira/browse/BEAM-13803?focusedWorklogId=723144&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-723144
]
ASF GitHub Bot logged work on BEAM-13803:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 08/Feb/22 20:32
Start Date: 08/Feb/22 20:32
Worklog Time Spent: 10m
Work Description: jrmccluskey commented on a change in pull request
#16775:
URL: https://github.com/apache/beam/pull/16775#discussion_r802034197
##########
File path: sdks/go/pkg/beam/core/runtime/graphx/translate.go
##########
@@ -418,7 +379,7 @@ func (m *marshaller) addMultiEdge(edge NamedEdge)
([]string, error) {
si[fmt.Sprintf("i%v", i)] = &pipepb.SideInput{
AccessPattern: &pipepb.FunctionSpec{
- Urn: URNMultimapSideInput,
+ Urn: URNIterableSideInput,
},
ViewFn: &pipepb.FunctionSpec{
Urn: "foo",
Review comment:
ViewFns are not currently implemented in the Go SDK but the proto
requires the field to be non-empty. So we put a dummy placeholder URN in place
for now. The WindowMappingFn field had the same set-up until I implemented the
basic window mapping functionality we use now.
"Required" fields in protos are a legacy thing that are discouraged/outright
unsupported now since they're a headache to deal with, generally.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 723144)
Time Spent: 3h (was: 2h 50m)
> Add native iterable side input support to the Go SDK
> ----------------------------------------------------
>
> Key: BEAM-13803
> URL: https://issues.apache.org/jira/browse/BEAM-13803
> Project: Beam
> Issue Type: Improvement
> Components: sdk-go
> Reporter: Jack McCluskey
> Assignee: Jack McCluskey
> Priority: P2
> Time Spent: 3h
> Remaining Estimate: 0h
>
> The current Go SDK side input implementation handles all side inputs as map
> side inputs, applying a fixed key to anything that is unkeyed and arranging
> things into the correct form after the fact. This should be changed to avoid
> adding an extra fixed key node and support iterable side inputs natively.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
