[ 
https://issues.apache.org/jira/browse/BEAM-12572?focusedWorklogId=723757&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-723757
 ]

ASF GitHub Bot logged work on BEAM-12572:
-----------------------------------------

                Author: ASF GitHub Bot
            Created on: 09/Feb/22 16:08
            Start Date: 09/Feb/22 16:08
    Worklog Time Spent: 10m 
      Work Description: benWize commented on pull request #16781:
URL: https://github.com/apache/beam/pull/16781#issuecomment-1033927278


   Hi @tvalentyn, after merging the cron jobs for the examples tests, some 
tests started to fail, for 
[Spark](https://ci-beam.apache.org/job/beam_PostCommit_Python_Examples_Spark/19/testReport/),
 
[Flink](https://ci-beam.apache.org/job/beam_PostCommit_Python_Examples_Flink/16/testReport/apache_beam.examples.dataframe.flight_delays_it_test/FlightDelaysTest/test_flight_delays/)
 and 
[Direct](https://ci-beam.apache.org/job/beam_PostCommit_Python_Examples_Direct/23/testReport/apache_beam.examples.dataframe.flight_delays_it_test/FlightDelaysTest/test_flight_delays/)
 `flight_delays_it_test` failed with an AssertionError, I think with the 
upgrade of pandas version, the assertion 
`pd.testing.assert_frame_equal(result_df, expected_df)` changed to more 
restrictive default values, so my suggested fix is to relax the condition 
because the results do not always return the same exact values. And for the 
case of 
[Dataflow](https://ci-beam.apache.org/job/beam_PostCommit_Python_Examples_Dataflow/21/testReport/junit/apache_beam.examples.complete.autocomplete_test/AutocompleteTest/test_autocomplete_output_files_on_small_input/)
 appeared the same errors of `RecursionError: maximum recursion depth 
exceeded`, here my suggested approach is the same as for the other runners, run 
the failed examples without pytest-xdist
   Could you help me to review this?
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Issue Time Tracking
-------------------

    Worklog Id:     (was: 723757)
    Time Spent: 43h 50m  (was: 43h 40m)

> All beam examples should get continuously exercised on at least 2 runners
> -------------------------------------------------------------------------
>
>                 Key: BEAM-12572
>                 URL: https://issues.apache.org/jira/browse/BEAM-12572
>             Project: Beam
>          Issue Type: New Feature
>          Components: testing
>            Reporter: Valentyn Tymofieiev
>            Assignee: Benjamin Gonzalez
>            Priority: P3
>          Time Spent: 43h 50m
>  Remaining Estimate: 0h
>
> Sometimes our examples become broken without us noticing. For example, see: 
> https://lists.apache.org/thread.html/r45340bbee91a6caf798fe62d24388f645f8792cc7506351fd66adec3%40%3Cdev.beam.apache.org%3E
> We should test our examples better.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

Reply via email to