[
https://issues.apache.org/jira/browse/BEAM-4032?focusedWorklogId=724030&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-724030
]
ASF GitHub Bot logged work on BEAM-4032:
----------------------------------------
Author: ASF GitHub Bot
Created on: 09/Feb/22 20:56
Start Date: 09/Feb/22 20:56
Worklog Time Spent: 10m
Work Description: AnandInguva commented on a change in pull request
#16633:
URL: https://github.com/apache/beam/pull/16633#discussion_r803080362
##########
File path:
sdks/python/apache_beam/examples/complete/check_requirements_file_packages.py
##########
@@ -0,0 +1,71 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
+"""A pipeline to verify the installation of packages specified in the
+ requirements.txt.
+ python check_requirements_file_packages.py \\
+ --runner=PortableRunner \\
+ --job_endpoint=embed \\
+ --requirements_file=./requirements.txt \\
+ --environment_type="DOCKER"
+"""
+
+import argparse
+import apache_beam as beam
+import logging
+
+from apache_beam.options.pipeline_options import PipelineOptions
+
+
+def run(argv=None):
+
+ _PACKAGE_IN_REQUIREMENTS_FILE = 'matplotlib'
+ _PACKAGE_NOT_IN_REQUIREMENTS_FILE = 'torch'
+
+ parser = argparse.ArgumentParser()
+ _, pipeline_args = parser.parse_known_args(argv)
+ pipeline_options = PipelineOptions(pipeline_args)
+
+ with beam.Pipeline(options=pipeline_options) as p:
+ result = (
+ p | beam.Create(
+ [_PACKAGE_IN_REQUIREMENTS_FILE,
_PACKAGE_NOT_IN_REQUIREMENTS_FILE]))
+
+ def assert_modules(p):
+ package_name, is_present = p[0], p[1]
+ if package_name == _PACKAGE_IN_REQUIREMENTS_FILE:
+ assert is_present, ('Please check if package %s is specified'
+ 'in requirements file' % package_name)
+ elif package_name == _PACKAGE_NOT_IN_REQUIREMENTS_FILE:
+ assert not is_present
+
+ def check_module_present(package_name):
+ import pkg_resources as pkg
+ try:
+ output = pkg.get_distribution(package_name)
+ except pkg.DistributionNotFound as e: # pylint: disable=unused-variable
+ output = None
+ if output is not None:
+ return package_name, True
+ return package_name, False
+
+ (result | beam.Map(check_module_present) | beam.Map(assert_modules)) #
pylint: disable=expression-not-assigned
+
Review comment:
Yes, it does fail if a package mentioned in the requirements text is not
installed on the container
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 724030)
Time Spent: 20h 50m (was: 20h 40m)
> Support staging binary distributions of dependency packages.
> ------------------------------------------------------------
>
> Key: BEAM-4032
> URL: https://issues.apache.org/jira/browse/BEAM-4032
> Project: Beam
> Issue Type: Improvement
> Components: sdk-py-core
> Reporter: Valentyn Tymofieiev
> Assignee: Anand Inguva
> Priority: P2
> Time Spent: 20h 50m
> Remaining Estimate: 0h
>
> requirements.txt only supports source-distribution dependencies [1].
> --extra_packages does not officially support wheel files [2].
> It is possible to expand this to support binary distributions as long as we
> have the knowledge of the target platform.
> We should take into consideration the mechanisms of staging dependencies
> through portability framework, and perhaps consolidate some of the existing
> options.
> [https://github.com/apache/beam/blob/a79d1b4fc27eb81db0d9a773047820a206f3d238/sdks/python/apache_beam/runners/dataflow/internal/dependency.py#L260]
> [https://github.com/apache/beam/blob/a79d1b4fc27eb81db0d9a773047820a206f3d238/sdks/python/apache_beam/runners/dataflow/internal/dependency.py#L188]
>
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
