[
https://issues.apache.org/jira/browse/BEAM-12572?focusedWorklogId=724093&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-724093
]
ASF GitHub Bot logged work on BEAM-12572:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 09/Feb/22 21:49
Start Date: 09/Feb/22 21:49
Worklog Time Spent: 10m
Work Description: TheNeuralBit commented on a change in pull request
#16781:
URL: https://github.com/apache/beam/pull/16781#discussion_r803116644
##########
File path: sdks/python/apache_beam/examples/dataframe/flight_delays_it_test.py
##########
@@ -125,7 +125,8 @@ def read_csv(path):
expected_df = expected_df.sort_values('airline').reset_index(drop=True)
try:
- pd.testing.assert_frame_equal(result_df, expected_df)
+ pd.testing.assert_frame_equal(
+ result_df, expected_df, check_dtype=False, atol=0.5)
Review comment:
For one I don't think check_dtype=False is necessary, secondly atol=0.5
is _very_ large. The default is 1e-8.
This is masking a difference of ~0.3 for expected result 23.823529 (~1%).
Which I don't think we should just gloss over.
It would be preferable to skip this test and file a jira blocking 2.37.0
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 724093)
Time Spent: 46h 20m (was: 46h 10m)
> All beam examples should get continuously exercised on at least 2 runners
> -------------------------------------------------------------------------
>
> Key: BEAM-12572
> URL: https://issues.apache.org/jira/browse/BEAM-12572
> Project: Beam
> Issue Type: New Feature
> Components: testing
> Reporter: Valentyn Tymofieiev
> Assignee: Benjamin Gonzalez
> Priority: P3
> Time Spent: 46h 20m
> Remaining Estimate: 0h
>
> Sometimes our examples become broken without us noticing. For example, see:
> https://lists.apache.org/thread.html/r45340bbee91a6caf798fe62d24388f645f8792cc7506351fd66adec3%40%3Cdev.beam.apache.org%3E
> We should test our examples better.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
