[
https://issues.apache.org/jira/browse/BEAM-13921?focusedWorklogId=724829&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-724829
]
ASF GitHub Bot logged work on BEAM-13921:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 10/Feb/22 22:37
Start Date: 10/Feb/22 22:37
Worklog Time Spent: 10m
Work Description: lostluck commented on a change in pull request #16815:
URL: https://github.com/apache/beam/pull/16815#discussion_r804189082
##########
File path: sdks/go/test/integration/integration.go
##########
@@ -123,6 +123,8 @@ var sparkFilters = []string{
// The trigger and pane tests uses TestStream
"TestTrigger.*",
"TestPanes",
+ // [BEAM-13921]: Spark doesn't support side inputs to executable stages
+ "TestDebeziumIO_BasicRead",
Review comment:
So, the tests listed in "integration.go" are only covering Go
integration tests. So, we added the test when we added the DebeziumIO transform
wrapper to the SDK.
In this case, we probably should have changes to the
.../go/test/integration/... directory trigger execution of all the post
commits/integration tests as part of the PR, to ensure they're run for all the
runners on addition or change.
We don't usually do this for arbitrary SDK changes, because they're much
heavier weight than the various unit tests, and similarly, the Same Suite of
tests is run against the Python Portable Runner as the "GoPortable Precommit",
and cases where missing Runner features are tickled by the Go SDK itself, are
rare.
But that's why this got hit I guess: The issue is triggered from Java SDK
code, not Go SDK code.
To sum up, this is the post commits WAI, but we should trigger them eagerly
for PRs that are adding new tests to the suite.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 724829)
Time Spent: 1h 20m (was: 1h 10m)
> validatesCrossLanguageRunnerGoUsingJava failing for beam_PostCommit_XVR_Spark
> ------------------------------------------------------------------------------
>
> Key: BEAM-13921
> URL: https://issues.apache.org/jira/browse/BEAM-13921
> Project: Beam
> Issue Type: Bug
> Components: cross-language, test-failures
> Reporter: Chamikara Madhusanka Jayalath
> Assignee: Ritesh Ghorse
> Priority: P1
> Time Spent: 1h 20m
> Remaining Estimate: 0h
>
> For example,
> https://ci-beam.apache.org/job/beam_PostCommit_XVR_Spark/3349/console
> https://ci-beam.apache.org/job/beam_PostCommit_XVR_Spark/3350/console
> https://ci-beam.apache.org/job/beam_PostCommit_XVR_Spark/3351/console
> Ritesh, is this related to recent Go wrapper updates ?
> cc: [~lostluck]
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
