[
https://issues.apache.org/jira/browse/BEAM-6994?focusedWorklogId=222790&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-222790
]
ASF GitHub Bot logged work on BEAM-6994:
----------------------------------------
Author: ASF GitHub Bot
Created on: 04/Apr/19 03:57
Start Date: 04/Apr/19 03:57
Worklog Time Spent: 10m
Work Description: lhaiesp commented on pull request #8221: [BEAM-6994]
SamzaRunner: further improvements for upgrading Samza
URL: https://github.com/apache/beam/pull/8221#discussion_r272009652
##########
File path:
runners/samza/src/main/java/org/apache/beam/runners/samza/translation/ConfigBuilder.java
##########
@@ -255,9 +230,40 @@ private static void validateYarnRun(Map<String, String>
config) {
configBuilder.put("job.host-affinity.enabled", "true");
}
+ switch (options.getSamzaExecutionEnvironment()) {
Review comment:
not sure whether we have logged the entire pipeline option somewhere.
Otherwise it would be good to have a log entry here about which execution
environment we're running
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 222790)
Time Spent: 40m (was: 0.5h)
> SamzaRunner: further improvements for upgrading Samza
> -----------------------------------------------------
>
> Key: BEAM-6994
> URL: https://issues.apache.org/jira/browse/BEAM-6994
> Project: Beam
> Issue Type: Improvement
> Components: runner-samza
> Reporter: Xinyu Liu
> Assignee: Xinyu Liu
> Priority: Major
> Time Spent: 40m
> Remaining Estimate: 0h
>
> More improvements for SamzaRunner:
> - Life cycle methods for the pipeline runtime
> - Hook up Samza ExternalContext for LinkedIin use cases
> - Support metrics reporters in pipeline options
> - Some bug fixes for the state key in Samza
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
