[
https://issues.apache.org/jira/browse/BEAM-6747?focusedWorklogId=222889&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-222889
]
ASF GitHub Bot logged work on BEAM-6747:
----------------------------------------
Author: ASF GitHub Bot
Created on: 04/Apr/19 09:51
Start Date: 04/Apr/19 09:51
Worklog Time Spent: 10m
Work Description: mxm commented on pull request #7954: [BEAM-6747] Adding
ExternalTransform in JavaSDK
URL: https://github.com/apache/beam/pull/7954#discussion_r272086231
##########
File path:
runners/core-construction-java/src/main/java/org/apache/beam/runners/core/construction/SdkComponents.java
##########
@@ -54,9 +54,11 @@
private final Set<String> reservedIds = new HashSet<>();
+ private String defaultEnvironmentId;
+
/** Create a new {@link SdkComponents} with no components. */
public static SdkComponents create() {
- return new SdkComponents("");
+ return new SdkComponents(null, "");
Review comment:
I would pass a default instance of `SdkComponents` instead of null, e.g.
`RunnerApi.Components.getDefaultInstance()`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 222889)
Time Spent: 3h 10m (was: 3h)
> Adding ExternalTransform in JavaSDK
> -----------------------------------
>
> Key: BEAM-6747
> URL: https://issues.apache.org/jira/browse/BEAM-6747
> Project: Beam
> Issue Type: Improvement
> Components: runner-core
> Reporter: Heejong Lee
> Assignee: Heejong Lee
> Priority: Major
> Time Spent: 3h 10m
> Remaining Estimate: 0h
>
> Adding Java counterpart of Python ExternalTransform for testing Python
> transforms from pipelines in Java SDK.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
